tests/sys/netinet: test route selected interface for mcast join #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* at requires cron, since atrun is started by cron and won't work without it, and also requires runtime because at runs jobs under /bin/sh. * bluetooth requires ppp for rfcomm_pppd (a very common use case). * bsdconfig and bsdinstall are written in shell script and therefore require /bin/sh. * devd requires /bin/sh to invoke its hooks. While here, document the policy for adding dependencies in the README. This will hopefully ensure we end up with consistent dependencies. MFC after: 1 day Reviewed by: bapt Differential Revision: https://reviews.freebsd.org/D52699
Provide at least a basic description of every package we build. Where possible, the description is taken from a relevant manpage; when there was no suitable text in the manpage, I wrote a new description. Since the UCL files now contain a significant amount of English prose which is almost certainly subject to copyright in at least some jurisdictions, add a copyright header to every file. Where the text was taken from a manpage, the copyright and license are also taken from the manpage. A few files don't have copyright headers added because the origin of the text is unclear, or because the files were written by someone else. While here, remove some orphaned UCL files for packages we no longer ship. MFC after: 1 day Reviewed by: bapt Differential Revision: https://reviews.freebsd.org/D52690
When NO_INSTALLKERNEL and NO_INSTALLEXTRAKERNELS are set, or when BUILDKERNELS is empty, we can fail to define the create-kernel-packages make target, which we call unconditionally. So if do not have a kernel staging dir, go ahead and provide an empty create-kernel-packages so that when it's used elsewhere, the build succeeds. This lets me build a tree and package it when I don't have a kernel, for jails and other similar environments. There's no change if any kernels are built, since that will provide the necessary make target that does useful things for that case. Sponsored by: Netflix
Consolidate examples to build the system in the build(7) manual where the details about the syntax involved is documented. Remove them from development(7), instead adding examples for patching the trees. They are left in UPDATING for now, to hopefully be removed eventually. Reduce documentation proliferation and create consistent, maintainable doc about building the system, eventually removing the COMMMON ITEMS section of UPDATING so there is a single source of truth in the cannon and well-integrated location, the in-band system reference manual. + Example 1: Build and upgrade system in place + Example 2: Build and upgrade a custom kernel in place + Example 3: Build and upgrade a single piece of userspace + Example 4: Build and upgrade a loadable kernel module + Example 5: Quickly rebuild a kernel in place + Example 6: Cross-compiling for different architectures The examples section of development(7) now contains examples for applying patches to the trees. There is certainy much more to do here, but it needs to be chunked. MFC after: 3 days Reviewed by: imp (previous version), ivy (previous version) Discussed with: emaste, imp, jhb, ivy Differential Revision: https://reviews.freebsd.org/D48693
Notable upstream pull request merges: #17705 545d662 Fix a printf format specifier on FreeBSD/i386 #17708 3387d34 Fix atomic-alignment warnings in libspl on FreeBSD/i386 #17719 f319ff3 vdev_disk_close: take disk write lock before destroying it #17732 1d2d812 Refactor `zhack label repair` and fix `-c` regression on nonzero TXG #17764 ea37c30 zdb: Fix asize overflow in verify_livelist_allocs() Obtained from: OpenZFS OpenZFS commit: b2196fb
This also indirectly addresses the lack of FreeBSD-lldb package on the riscv64 platform by relying on that package being part of the FreeBSD-set-devel set iff it exists. A subsequent commit will adjust the "notoolchain" OCI container image to also use a package set, which will indirectly affect the contents of the "toolchain" container (which is an explicit superset of the "notoolchain" container). MFC after: 1 day Co-authored-by: dch
Refactor tcp_send_challenge_ack() such that the logic checking whether a challenge ACK is sent or not is available in the separate function tcp_challenge_ack_check(). This new function will also be used for sending challenge ACKs in the SYN-cache code, which will be added in upcoming commits. No functional change intended. Reviewed by: cc, Nick Banks, Peter Lei MFC after: 3 days Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D52717
to avoid recursion on u2f mutex and taking of hidbus sleepable lock. Tested by: emaste PR: 289494 MFC after: 2 days
This makes non-GENERIC kernel configs easier to maintain. Requested by: glebius MFC after: 2 days
Reviewed by: bapt Differential Revision: https://reviews.freebsd.org/D52697
Reviewed by: bcr Differential Revision: https://reviews.freebsd.org/D52698
The flag is guarded by proc lock which is already held.
After tracing poudriere for over 4 hours like so:
dtrace -n 'fbt::do_fork:entry { @[curthread->td_proc->p_flag & 0x2] = count(); }':
2 15605151
0 20074116
Over 56% of cases did not have P_CONTROLT set and could have avoided the
lock.
This reduces hold time of the proctree lock.
This will allow the VM image build scripts to use the same repository config file for installing base system packages at build time. Reviewed by: emaste Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D51482
Add support for one shot rules that remove themselves from an active
ruleset after match.
This is an extremely handy technique for firewall proxies.
ok henning, mcbride
Note that the FreeBSD implementation differs significantly from the OpenBSD
version due to locking differences. We do not remove the rule, but mark it as
having fired previously so we can skip it.
Obtained from: OpenBSD, mikeb <mikeb@openbsd.org>, c981122504
Obtained from: OpenBSD, sashan <sashan@openbsd.org>, a21b78cad0 (partial)
Sponsored by: Rubicon Communications, LLC ("Netgate")
…ilter option.
ok henning, mcbride
Obtained from: OpenBSD, mikeb <mikeb@openbsd.org>, 44b1b5a8a9
Sponsored by: Rubicon Communications, LLC ("Netgate")
Sponsored by: Rubicon Communications, LLC ("Netgate")
…les.
ok henning, mcbride, jmc
Obtained from: OpenBSD, mikeb <mikeb@openbsd.org>, 355f9a50c1
Sponsored by: Rubicon Communications, LLC ("Netgate")
ok henning
Obtained from: OpenBSD, mikeb <mikeb@openbsd.org>, 47068a62ee
Sponsored by: Rubicon Communications, LLC ("Netgate")
Obtained from: OpenBSD, sashan <sashan@openbsd.org>, 8cf23eed7f
Sponsored by: Rubicon Communications, LLC ("Netgate")
* Merge `once' handling from `anchorrule' and `pfrule'
* Remove/shorten duplicate code block
OK sashan
Obtained from: OpenBSD, kn <kn@openbsd.org>, d114b77333
Sponsored by: Rubicon Communications, LLC ("Netgate")
parse.y revision 1.682 from 16.07.2018 errornously allowed `match once' and
`anchor "a" once'.
Fix both by checking for PF_DROP not PF_MATCH and creating anchors in the
parser already such that they can be used to distinguish anchor rules in
the same check as well.
Found and fixed by Petr Hoffmann <petr.hoffmann at oracle dot com>, thanks!
While here, remove an unneeded cast and make pfctl_add_rule() void as it
always returned 0.
OK sashan
Obtained from: OpenBSD, kn <kn@openbsd.org>, 6da84b37b3
Sponsored by: Rubicon Communications, LLC ("Netgate")
let packet to mark 'once' rule as expired. The rule
will be removed by pfctl(8) when rules are updated.
OK kn@
Obtained from: OpenBSD, sashan <sashan@openbsd.org>, a21b78cad0
Obtained from: OpenBSD, jmc <jmc@openbsd.org>, 588f4160c8
Sponsored by: Rubicon Communications, LLC ("Netgate")
- use imperative tense in the pf.conf(5) "once" part
- leave printing implementation details to pfctl(8)'s "-s rules" part
- use more markup
- debug mode also prints expired rules
OK jmc sashan
Obtained from: OpenBSD, kn <kn@openbsd.org>, 1f1797aba7
Sponsored by: Rubicon Communications, LLC ("Netgate")
After the refactoring in 'pfctl: fix once rules' we broke nat/rdr/binat rules.
These no longer exist on OpenBSD, so were not considered in that patch. Factor
out the common code and call it from all anchor types.
Sponsored by: Rubicon Communications, LLC ("Netgate")
Sponsored by: Rubicon Communications, LLC ("Netgate")
Sponsored by: Rubicon Communications, LLC ("Netgate")
We already track this in the kernel and pass it to userspace, we may as well
show users.
Sponsored by: Rubicon Communications, LLC ("Netgate")
The 'rule_numbers' is used for more than just displaying rule numbers.
Rename it and move the actual opts checking into the relevant functions.
Sponsored by: Rubicon Communications, LLC ("Netgate")
time_t has a different size on different platforms (i.e. 32-bit on i386, 64-bit
on others). Rather than always exporting it as 64-bits use the platform-native
size.
This means we can safely write directly into a time_t variable, which we can't
do on i386 eif we export 64 bits.
Sponsored by: Rubicon Communications, LLC ("Netgate")
This manual contains nothing and is only suitable for the HW Relnotes, but lets get it in so we have something and then can iterate on it. MFC after: 3 minutes Fixes: 2ed9833 (thunderbolt: Import USB4 code) Discussed with: obiwac Differential Revision: https://reviews.freebsd.org/D52847
This manual only describes a tiny amount suitable for the HW Relnotes. Remove the description section and replace it with a hardware section which will appear there. MFC after: 3 minutes Reported by: ivy History Ref: 5bcb64f (Add mmc and mmcsd)
It is available on all supproted FreeBSD versions. Sponsored by: The FreeBSD Foundation
Reviewed by: ivy Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D52857
MFC after: 1 hr Reported by: emaste Fixes: 2f7a796 (thunderbolt.4: Initial manual)
Also add cross-references to hkbd.4 and hms.4. Sponsored by: The FreeBSD Foundation
When clearing pmcntenclr_el0, pmintenclr_el1, and pmovsclr_el0 clear all bits as new fields may be added in the upper 32-bits. Sponsored by: Arm Ltd Differential Revision: https://reviews.freebsd.org/D52801
These were missed in the initial vmm.ko change. While here keep the order the same in all locations we handle these. Sponsored by: Arm Ltd Differential Revision: https://reviews.freebsd.org/D52802
It may be used by the guest. Sponsored by: Arm Ltd Differential Revision: https://reviews.freebsd.org/D52803
To be consistent within the register prefix all fields with MDCR_EL2_. Reviewed by: emaste Sponsored by: Arm Ltd Differential Revision: https://reviews.freebsd.org/D52804
Move the MDCR_EL2 macros into the correct alphabetical location. Sponsored by: Arm Ltd Differential Revision: https://reviews.freebsd.org/D52805
These are features we don't support or advertise to the guest so can safely be trapped. Sponsored by: Arm Ltd Differential Revision: https://reviews.freebsd.org/D52806
Also convert nearby ATF_REQUIRE_MSG to ATF_REQUIRE_INTEQ_MSG. Reported by: GCC -Wint-in-bool-context Reviewed by: asomers, des Differential Revision: https://reviews.freebsd.org/D45893
- Use git to detect the latest stable branch rather than hardcoding it. - Handle the case where the script is run outside a src or ports repository. - Fix a pattern to match .git instead of *git. Reviewed by: andrew, releng (emaste) Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D52681
PR: 280377 Sponsored by: The FreeBSD Foundation
While here, break a long line that agitates the linter. Fixes: cc16f1b (Add umass.c) MFC after: 1 hour Discussed with: imp, ivy diff --git a/sys/dev/usb/FILES b/sys/dev/usb/FILES
Reported by: Bruno Silvestre
List deleted entries prefixed by "#". This is consistent with other ippool list functions. Fixes: 7531c43 MFC after: 1 week
To maintain consistency with ippool list functions, prefix deleted entries with "#". MFC after: 1 week
As with 7531c43, which dumped ippool table data in the "new" format, print hash data in the "new" format. MFC after: 1 week
As with 7531c43, which dumped ippool table data in the "new" format, print dstlist data in the "new" format. MFC after: 1 week
While processing SCTP packets we can enqueue work for later, in the
sctp_multihome_jobs queue. This deferred job includes a copy of the current
struct pf_pdesc, which must contain a valid pcksum pointer (in case of NAT).
However, jobs could be enqueued before we'd actually set this pointer in
pf_setup_pdesc(). Set this pointer before we scan the SCTP chunk headers (and
could enqueue deferred jobs.)
While here sprinkle in a few more assertions to ensure we got this right.
Reported-by: syzbot+974d0fb7e53c9aa31b90@syzkaller.appspotmail.com
MFC after: 3 days
Sponsored by: Rubicon Communications, LLC ("Netgate")
We returned 'PF_DROP' instead of '-1' in one case, which would lead to us
continuing the processing for an invalid packet.
This also aligns us closer to OpenBSD, and reduces the odds of future similar
mixups.
MFC after: 3 days
Sponsored by: Rubicon Communications, LLC ("Netgate")
The syncache entry is locked by the hash bucket lock. After running SCH_UNLOCK(), we have no guarantee that the syncache entry still exists. Resolve the race by moving SCH_UNLOCK() after the log() call which reads variables from the syncache entry. Reviewed by: rrs, tuexen, Nick Banks Sponsored by: Netflix MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D52868
If an rdr (or nat) rule specifies 'pass' we don't run the filter rules, we just
pass the traffic. Or at least, we did until that got unintentionally broken.
Restore that behaviour and add a test case.
While here also fix nat:dummynet_mask, which relied on the broken behaviour.
MFC after: 3 days
Sponsored by: Rubicon Communications, LLC ("Netgate")
Differential Revision: https://reviews.freebsd.org/D52838
PR: 289948 Approved by: eduardo (mentor)
we expect route based selection of proper interface, aligning with linux implementation
|
Thank you for taking the time to contribute to FreeBSD!
Please review CONTRIBUTING.md, then update and push your branch again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.