Add initial tests for 'globus endpoint search' #1071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the necessary mocking framework pieces to have a simulated endpoint search response, and a test against that response.
For simplicity, just check that the value passed appears in the full URL.
sirosen
requested review from
MaxTueckeGlobus,
derek-globus,
kurtmckee and
m1yag1
as code owners
kurtmckee
requested changes
Jan 13, 2025
Comment on lines
+115
to
+119
| "GCP_mapped_collection", | ||
| "GCP_guest_collection", | ||
| "GCSv5_endpoint", | ||
| "GCSv5_mapped_collection", | ||
| "GCSv5_guest_collection", |
Member
There was a problem hiding this comment.
Do these values appear in an enum somewhere? If so, it will be worthwhile to use that enum directly (or perhaps to compose this list and then make assertions that it matches the enum).
Member
Author
There was a problem hiding this comment.
They do not appear in an enum (IMO, "thank goodness", str enums are so clunky...).
They're in a Literal type annotation.
Would you like me to write the "magic" to extract them from that annotation? I've done it before and it's pretty easy, but it adds a little bit of complexity to the test module.
- explode space split strings into sets and sanity check - refine internal helper params and fixture metadata - make test criteria for table output clearer - parse the query string for testing - also, test name normalization of the filter_entity_type param
kurtmckee
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command has not had any functional test coverage, so these are the first tests for the command.
--filter-entity-typewas added in #1055, but it was not possible to test it at the time because we had no fixture data to work off of.To build initial data, I grabbed a live service search result and rewrote it thoroughly to remove my account and collection details.
@pjhinton-globus, the second commit here shows what I wanted you to be able to add.
When I realized that we'd need to setup new fixture data for endpoint search, I felt it was unfair to ask for this as part of an incremental addition to an existing, untested command.
I haven't discussed my decision to use
str.split()to build out the data with anyone yet, which is probably the most contentious thing I've done here.