Add ComputeClientV3 methods to manage endpoints #1113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmello
requested review from
MaxTueckeGlobus,
aaschaer,
ada-globus,
derek-globus,
kurtmckee,
m1yag1 and
sirosen
as code owners
rjmello
requested review from
a user,
LeiGlobus,
chris-janidlo,
khk-globus and
ryanchard
khk-globus
reviewed
Nov 22, 2024
Contributor
khk-globus
left a comment
khk-globus
left a comment
There was a problem hiding this comment.
Also thinking at this time that you may want to add yourself (and anyone else appropriate from our team) to CODEOWNERS. Maybe not for this PR — or maybe for the associated paths in this PR?
kurtmckee
requested changes
Nov 22, 2024
rjmello
force-pushed
the
compute-client-endpoint-methods-v3
branch
from
ee939b3 to
7d7a12d
Compare
Added `.register_endpoint()`, `.update_endpoint()`, `.lock_endpoint()`, and `.get_endpoint_allowlist()` methods to the `ComputeClientV3` class.
rjmello
force-pushed
the
compute-client-endpoint-methods-v3
branch
from
7d7a12d to
16b1981
Compare
kurtmckee
approved these changes
Nov 22, 2024
khk-globus
approved these changes
Nov 22, 2024
Contributor
khk-globus
left a comment
khk-globus
left a comment
There was a problem hiding this comment.
Approving, so as to not block the general consensus.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
.register_endpoint(),.update_endpoint(),.lock_endpoint(), and.get_endpoint_allowlist()methods to theComputeClientV3class.📚 Documentation preview 📚: https://globus-sdk-python--1113.org.readthedocs.build/en/1113/