Fix incorrect type in ClientApp init signature #1360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirosen
requested review from
MaxTueckeGlobus,
aaschaer,
ada-globus,
derek-globus,
kurtmckee and
m1yag1
as code owners
`scope_requirements` was annotated as `dict` in init for `ClientApp`, but the base class, `UserApp`, and the `add_scope_requirements` method all accept a `Mapping` -- allowing for an immutable mapping type. To confirm the fix, the typing test which currently checks the scope requirements type of app objects is expanded to cover - both UserApp and ClientApp - `add_scope_requirements` and `__init__` - a `dict` which is a subtype of `Mapping[K, V]` but not of `dict[K, V]` (for our specific `K, V`) and a `types.MappingProxyType` (an immutable dict proxy) fixes globus#1358
sirosen
force-pushed
the
fix-typing-strictness-bug
branch
from
95be8ba to
91837ea
Compare
derek-globus
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scope_requirementswas annotated asdictin init forClientApp, butthe base class,
UserApp, and theadd_scope_requirementsmethod allaccept a
Mapping-- allowing for an immutable mapping type.To confirm the fix, the typing test which currently checks the scope
requirements type of app objects is expanded to cover
add_scope_requirementsand__init__dictwhich is a subtype ofMapping[K, V]but not ofdict[K, V](for our specific
K, V) and atypes.MappingProxyType(an immutabledict proxy)
fixes #1358