-
Notifications
You must be signed in to change notification settings - Fork 0
Adding low-rank covariance #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vivianwhite
wants to merge
77
commits into
dev
Choose a base branch
from
new_experiments
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
77 commits
Select commit
Hold shift + click to select a range
fb83f37
adding files from muawi_resnets
vivianwhite 0f10d2c
removing comments and unused lines
vivianwhite e3ab5ba
remove comments and unused lines
vivianwhite 8411f74
fixed and tested conv_modules
vivianwhite fe6cbc7
add whitespace
vivianwhite a472f7d
add whitespace
vivianwhite 2ec009e
trying to setup define_models
vivianwhite 122c758
fixed models dir
vivianwhite 28841fe
Delete models directory
vivianwhite 7ddc12c
add utils file
vivianwhite 55670ba
fix white spaces
vivianwhite a779085
fixing V1 cifar10 model
vivianwhite b873254
add replace_linears function
vivianwhite 204bf3a
adding recursive functions script
vivianwhite 2aeaf98
some updates, more to come tomorrow
vivianwhite 6a236c5
Delete refactor/resnet.py
vivianwhite a9317a7
update define_model options
vivianwhite 11d9477
normalization back to normal
vivianwhite 6905850
updates anda adding turn_off_grad function
vivianwhite aa28aab
adding V1-init functionality
vivianwhite e537fda
updating v1-init
vivianwhite 15b8cd5
cleanup
vivianwhite 29978b4
initial commit of refactored rainbow (have not run anything yet)
MuawizChaudhary 82180c4
minimal changes to ensure this script runs
MuawizChaudhary 09aade2
cleanup, modified print statements, added seed argument, removed widt…
MuawizChaudhary 6c6dcc9
removed affine argument
MuawizChaudhary 15422ab
moved recursive modules around
MuawizChaudhary 1397314
added recurse_preorder. made each replace function a wrapper that ret…
MuawizChaudhary 44da047
removed fact_2_conv
MuawizChaudhary a4bf746
changes
MuawizChaudhary fff0899
did TODOs
vivianwhite f36a459
noting origin of code
vivianwhite 38de471
added class conditional decerators. added looping over multiple callb…
MuawizChaudhary 0cca6a1
Revert to 09f4833
MuawizChaudhary 42f7542
seperated rainbow functionality from runner script
MuawizChaudhary fff82a5
changes to rainbow sampling so we can sample multiple times and calcu…
MuawizChaudhary 1dd2048
refactored a decent amount of rainbow sampling
MuawizChaudhary 5f44973
fact-conv changes
MuawizChaudhary 657db4f
reduce amount of code in rainbow
MuawizChaudhary c680aea
initalize with empty_like instead
MuawizChaudhary edda0b4
added verbose option
MuawizChaudhary 68e84e4
removed my beloved og
MuawizChaudhary 07803e0
deleted learnable_cov.py which had been renamed to V1_covariance.py
MuawizChaudhary 6594292
width scaling should be first
MuawizChaudhary c078cfc
making rainbow sampling more like a properly called class. similar to…
MuawizChaudhary 642c480
removed specification of device from init, rely instead on layer to p…
MuawizChaudhary d3116ec
formatting changes
MuawizChaudhary 992e98b
formatting
MuawizChaudhary 0d0d60f
added README.md
MuawizChaudhary 2b48a03
added citation to README.md
MuawizChaudhary 9dc5666
Update README.md
MuawizChaudhary 01b39c8
renaming folder
vivianwhite c92f6ac
Delete layers directory
vivianwhite e05bbcd
Delete refactor directory
vivianwhite 0a1c34b
moving scripts
vivianwhite 428ae58
Delete V1-models/scripts/s_f_sweep directory
vivianwhite c6fa1a4
updating LC RSN scripts
vivianwhite 345a598
removing hardcoded stuff
vivianwhite 1c5295f
fixed save dir
vivianwhite 1b080e9
fixed save dir
vivianwhite 2ae3414
new experiments
MuawizChaudhary 378cbd9
implementing diag factconv2d
vivianwhite 2ffc071
minor changes
MuawizChaudhary 74aa5a3
conv_modules.py
vivianwhite 2366ef8
add diagchan, call by setting args.net='resnet18-diagchan'
vivianwhite c720d95
added low-rank setup
vivianwhite 4a04e1d
low-rank experiments
vivianwhite 0342b2e
adding covariance module
vivianwhite a8c7b5d
adding learnable low-rank diagonal covariance
vivianwhite ec927a4
adding low rank experiments
vivianwhite 5cceccb
updating covariance modules
vivianwhite 5513509
logging param count
vivianwhite f5f70f9
update turn_off_covar_grad function
vivianwhite 0a2e945
adding LearnableCov.py back
vivianwhite 1f9f43c
adding nonlinearities study
vivianwhite db9ba1b
adding resnext model
vivianwhite de9820b
added diagonally dominant experiment and updated scripts
vivianwhite File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This entire script, your re-using alot of code. I wonder if you could subclass FactConv extensions using this factconv module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as you mentioned, eventually we should refactor the other fact convs to use the covariance module.