Skip to content

show theme based male/female colors in callout#6

Open
HerzScheisse wants to merge 2 commits intogmarcon:mainfrom
HerzScheisse:show_gender
Open

show theme based male/female colors in callout#6
HerzScheisse wants to merge 2 commits intogmarcon:mainfrom
HerzScheisse:show_gender

Conversation

@HerzScheisse
Copy link
Copy Markdown
Contributor

this is just a idea... there may be room for simplified code esp. in the CSS file to shorten the duplicated .callout-dot classes

2026-01-15 00_03_45-Zeitreise-Karte - André Holger Eisold – Familienforschung eisold family — Mozill

this is just a idea... there may be room for simplified code esp. in the CSS file to shorten the duplicated .callout-dot classes

Signed-off-by: Holger Eisold <github@eisold.family>
@HerzScheisse
Copy link
Copy Markdown
Contributor Author

hi @gmarcon

I've updated this PR to include your latest changes... please let me know if you have any questions or if you dont agree with this PR feel free to close :)

Thanks

@HerzScheisse HerzScheisse marked this pull request as draft January 17, 2026 14:25
this is just a idea... there may be room for simplified code esp. in the CSS file to shorten the duplicated .callout-dot classes

Signed-off-by: Holger Eisold <github@eisold.family>
@HerzScheisse HerzScheisse marked this pull request as ready for review January 17, 2026 14:42
@gmarcon
Copy link
Copy Markdown
Owner

gmarcon commented Jan 17, 2026

Hi Holger,, thank you very much for all your contributions to the module including this one.

I hope you do not mind if I ponder still a bit about this proposal to have the dot represent the sex, I am playing with using the color of the dot to represent the distance from the root individual, and I would like to have a way to represent in the dot the lineage (for which I am still missing a good idea).

@HerzScheisse
Copy link
Copy Markdown
Contributor Author

hey, its absolutely no problem.. no worries...
I understand this... and as always all my changes are only suggestions... feel free to merge or close them...

I'll keep these changes in my seperate branch... so you can close this of you wish...

thanks again for this great module!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants