Conversation
- Add docs job to testing.yaml that runs mkdocs build --strict - Remove paths-ignore so docs-only PRs still get CI - Add docs.yaml workflow to deploy to GitHub Pages on push to main (when docs/ or rejected/ change), on release, or manually Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
📝 WalkthroughWalkthroughThe PR introduces automated documentation deployment via GitHub Actions. A new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/testing.yaml (1)
2-6: Consider path-based job filtering if CI time becomes a concern.Removing
paths-ignoremeans docs-only changes now run the full test matrix across Python 3.11–3.14. This is a valid choice for ensuring comprehensive validation, but if CI latency becomes problematic, you could add path-based conditions at the job level:test: if: | github.event_name == 'pull_request' || contains(github.event.head_commit.modified, 'rejected/') || contains(github.event.head_commit.modified, 'tests/')Or use
dorny/paths-filterfor more granular control. This is entirely optional for now.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/testing.yaml around lines 2 - 6, The workflow currently triggers on pull_request and push (under the on: pull_request / push keys) and no longer uses paths-ignore, so if CI time becomes a concern add path-based filtering at the job level (e.g., update the test job named "test" to include an if: condition that checks github.event_name and modified paths or integrate the dorny/paths-filter action) to skip running the full matrix for docs-only changes; modify the "test" job's definition to include either an if clause referencing github.event.head_commit.modified or wire in the dorny/paths-filter step before the matrix to gate execution.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/testing.yaml:
- Around line 2-6: The workflow currently triggers on pull_request and push
(under the on: pull_request / push keys) and no longer uses paths-ignore, so if
CI time becomes a concern add path-based filtering at the job level (e.g.,
update the test job named "test" to include an if: condition that checks
github.event_name and modified paths or integrate the dorny/paths-filter action)
to skip running the full matrix for docs-only changes; modify the "test" job's
definition to include either an if clause referencing
github.event.head_commit.modified or wire in the dorny/paths-filter step before
the matrix to gate execution.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: fcfb1536-b2f3-42ba-bf77-1b5ef2a01d13
📒 Files selected for processing (2)
.github/workflows/docs.yaml.github/workflows/testing.yaml
Summary
docsjob totesting.yamlthat runsmkdocs build --stricton PRs and pushespaths-ignorefrom testing workflow so docs-only PRs still get CIdocs.yamlworkflow to deploy docs to GitHub Pages on push to main (whendocs/,mkdocs.yml, orrejected/change), on release, or via manual dispatchTest plan
🤖 Generated with Claude Code
Summary by CodeRabbit