Skip to content

Add top-level setup.py#36

Open
chajath wants to merge 3 commits intogmum:mainfrom
chajath:main
Open

Add top-level setup.py#36
chajath wants to merge 3 commits intogmum:mainfrom
chajath:main

Conversation

@chajath
Copy link
Copy Markdown

@chajath chajath commented Sep 28, 2022

With this, we can now pip install directly from the repo dir.

See #35.

We can potentially package up experiments as an extra installable (i.e., via huggingmolecules[experiments]). I will do in a follow-up if necessary.

@panpiort8
Copy link
Copy Markdown
Collaborator

Thank you very much for the engagement!
The code looks good, but the PR indeed needs some more work to sew it up:

  • update Installation guide in README.md,
  • as you suggested, package the experiments module.

If you are willing to do the tasks, I'll be really glad :) if not, simply let me know, and I will take this PR over.

@chajath
Copy link
Copy Markdown
Author

chajath commented Oct 24, 2022

Hi! Sorry I won't have the bandwidth to follow up on the changes. Please feel free to take this PR over.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants