fix(gnovm): enforce int type for untyped variadic arguments in make#5249
fix(gnovm): enforce int type for untyped variadic arguments in make#5249thehowl merged 20 commits intognolang:masterfrom
Conversation
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
thehowl
left a comment
There was a problem hiding this comment.
also a proposal, why don't we make the arg in uverse Vrd(IntT())?
…/gno into fix/maxwell/enforce_varg_type
Vrd(IntT()) is too restrictive because it forces the variadic argument type in make's len/cap parameters to be exactly we can introduce a new constraint type to make it like However, inspired by this, a check for typed arguments is added, as demonstrated in varg_3.gno. |
…ake flag Move the int-type enforcement for make's variadic size arguments directly into the `case "make":` special-case block, eliminating the need for the `isBuiltinMake` boolean that coupled the ENTER and LEAVE phases.
refactor(gnovm): inline make varg type enforcement, remove isBuiltinMake flag
…5249) Co-authored-by: Morgan Bazalgette <morgan@morganbaz.com>
No description provided.