Skip to content

Fix notice#121

Open
gnugat wants to merge 3 commits intomainfrom
fix-notice
Open

Fix notice#121
gnugat wants to merge 3 commits intomainfrom
fix-notice

Conversation

@gnugat
Copy link
Copy Markdown
Owner

@gnugat gnugat commented Apr 5, 2015

Fixes issue #120

@gnugat gnugat added the bug label Apr 5, 2015
@gnugat gnugat self-assigned this Apr 5, 2015
@pyrech
Copy link
Copy Markdown
Contributor

pyrech commented Apr 5, 2015

👍
Will you squash your commits before merging? I don't think the first commit and the revert should appear in the history 😉

@gnugat
Copy link
Copy Markdown
Owner Author

gnugat commented Apr 5, 2015

Thanks for the review @pyrech, I've squashed the commits. We'll wait for more information on the issue before merging (I'd like to add a test for it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants