SC client supports the setting of diffAzAddress for a pool #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SC client supports the setting of diffAzAddress for a pool
humingcheng
reviewed
Jul 3, 2025
addresspool/pool.go
Outdated
| }) | ||
| } | ||
| if len(opts[0].DiffAzEndponits) != 0 { | ||
| p.diffAzAddress = opts[0].DiffAzEndponits |
Collaborator
There was a problem hiding this comment.
我们要达成的目标是，diffAzAddress的值永远是非空。
而在当前的代码中中，这个值会被定时刷新修改，要确保他无论如何都不会被清空。
要么修改代码，让其在初始化完成后不会被修改。
要么在修改diffAzAddress的逻辑上做严格的UT保护。
SC client supports the setting of diffAzAddress for a pool
Add test cases.
humingcheng
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC client supports the setting of diffAzAddress for a pool