feat: delete user test #45
Conversation
lifehou5e
requested review from
Kalachevskyi,
andstepko and
vpakhuchyi
as code owners
| func TestUserHandler_DeleteUser(t *testing.T) { | ||
| logger, err := lgr.New("INFO") | ||
| if err != nil { | ||
| t.FailNow() |
There was a problem hiding this comment.
Looks like you are loosing the err and will have no chance to investigate what happened.
There was a problem hiding this comment.
I'm using t.Logf() now, is this the right way?
There was a problem hiding this comment.
Looks like you are loosing the
errand will have no chance to investigate what happened.
Victor used this as example in video lection. You say its not good idea. Who's right?
But then Volodymyr said all code is bullshit )
There was a problem hiding this comment.
Welcome to software development!
There was a problem hiding this comment.
Chance to get an error there is too little.
Anyway, if you want to cover that - log that error. That's it.
Anton-Hudz
requested review from
Anton-Hudz
and removed request for
Anton-Hudz
|
Kudos, SonarCloud Quality Gate passed!
|
No description provided.