Merged
Conversation
Collaborator
|
LGTM there are some examples failing in latest go version, i'll fix those |
worg
approved these changes
Nov 5, 2025
Author
thanks, I did notice those, I wasn't exactly sure how you wanted them fixed, which is why I held off. |
Collaborator
|
fixed the pipeline, please update your branch |
Found a deadlock scenario that I hit. 1. A user calls Disconnect(), which locks c.closeMutex. 2. At the same time, the processLoop goroutine encounters a network error and calls MustDisconnect(). 3. MustDisconnect() blocks, waiting to acquire c.closeMutex, which is held by Disconnect(). 4. Since processLoop is now blocked, it can no longer read from c.writeCh. 5. Disconnect() blocks forever, waiting to send the DISCONNECT frame to c.writeCh (if the channel is full) or waiting for a RECEIPT that will never arrive because processLoop is stuck. Resolved by adding a sendFrame with a timeout, and no longer holding the closeMutex. Also found other situations where Ack/Nack would cause deadlock conditions. Those were also resolved.
mfmarche
force-pushed
the
handle_disconnect_deadlock
branch
from
9c99c3a to
5bbf998
Compare
Author
|
thanks @worg! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found a deadlock scenario that I hit.
Resolved by adding a sendFrame with a timeout, and no longer holding the closeMutex.
Also found other situations where Ack/Nack would cause deadlock conditions. Those were also resolved.