fix: always close multipart form writer to write closing boundary#265
Open
sylas00 wants to merge 1 commit intogo-telegram:mainfrom
Open
fix: always close multipart form writer to write closing boundary#265sylas00 wants to merge 1 commit intogo-telegram:mainfrom
sylas00 wants to merge 1 commit intogo-telegram:mainfrom
Conversation
When a method has no parameters (e.g. getMe, getMyCommands), form.Close() was skipped because it was inside the params nil-check block. This left the request body empty while the Content-Type header still declared a multipart boundary, producing a malformed request. Strict self-hosted Bot API servers reject such requests with HTTP 400 and an empty response body, causing the client to fail with: "error decode response body for method getMe, , unexpected end of JSON input" Move form.Close() outside the nil-check so the closing boundary (--boundary--) is always written, regardless of whether there are any form fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a method has no parameters (e.g. getMe, getMyCommands), form.Close() was skipped because it was inside the params nil-check block. This left the request body empty while the Content-Type header still declared a multipart boundary, producing a malformed request.
Strict self-hosted Bot API servers reject such requests with HTTP 400 and an empty response body, causing the client to fail with:
"error decode response body for method getMe, , unexpected end of JSON input"
Move form.Close() outside the nil-check so the closing boundary (--boundary--) is always written, regardless of whether there are any form fields.