Skip to content

chore(deps): bump deps and address urfave v3 breaking changes#1307

Merged
ecrupper merged 1 commit intomainfrom
deps/5-5-25
May 6, 2025
Merged

chore(deps): bump deps and address urfave v3 breaking changes#1307
ecrupper merged 1 commit intomainfrom
deps/5-5-25

Conversation

@ecrupper
Copy link
Copy Markdown
Contributor

@ecrupper ecrupper commented May 5, 2025

Always nice to be able to ditch a util function

See urfave/cli#2094 for more context on the urfave updates

@ecrupper ecrupper requested a review from a team as a code owner May 5, 2025 14:13
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2025

Codecov Report

Attention: Patch coverage is 52.94118% with 8 lines in your changes missing coverage. Please review.

Project coverage is 56.72%. Comparing base (35e61d8) to head (7b94bfe).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/vela-server/server.go 0.00% 5 Missing ⚠️
api/types/settings/platform.go 0.00% 1 Missing ⚠️
cmd/vela-server/scm.go 0.00% 1 Missing ⚠️
compiler/native/native.go 66.66% 1 Missing ⚠️

❌ Your project status has failed because the head coverage (56.72%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1307      +/-   ##
==========================================
+ Coverage   56.71%   56.72%   +0.01%     
==========================================
  Files         636      636              
  Lines       35676    35668       -8     
==========================================
  Hits        20232    20232              
+ Misses      14823    14815       -8     
  Partials      621      621              
Files with missing lines Coverage Δ
cmd/vela-server/flags.go 100.00% <100.00%> (ø)
database/context.go 90.00% <100.00%> (ø)
database/flags.go 68.18% <ø> (ø)
scm/flags.go 100.00% <ø> (ø)
util/util.go 20.19% <ø> (+1.44%) ⬆️
api/types/settings/platform.go 71.05% <0.00%> (ø)
cmd/vela-server/scm.go 0.00% <0.00%> (ø)
compiler/native/native.go 80.88% <66.66%> (ø)
cmd/vela-server/server.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

@delta592 delta592 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@ecrupper ecrupper merged commit be3567b into main May 6, 2025
16 of 17 checks passed
@ecrupper ecrupper deleted the deps/5-5-25 branch May 6, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants