Skip to content

fix(cancel): follow through cancel on missing executor#1441

Merged
ecrupper merged 3 commits intomainfrom
fix/allow-cancel-of-orphan
Apr 15, 2026
Merged

fix(cancel): follow through cancel on missing executor#1441
ecrupper merged 3 commits intomainfrom
fix/allow-cancel-of-orphan

Conversation

@ecrupper
Copy link
Copy Markdown
Contributor

If build is nil from CancelRunning, that doesn't mean we shouldn't go through with canceling. This will empower both auto cancel and other users to set a build status to canceled even if it's technically no longer accessible to the worker / in a weird state.

@ecrupper ecrupper requested a review from a team as a code owner April 15, 2026 15:56
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2026

Codecov Report

❌ Patch coverage is 0% with 46 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.01%. Comparing base (5b339d8) to head (9185927).

Files with missing lines Patch % Lines
api/build/cancel.go 0.00% 35 Missing ⚠️
api/build/auto_cancel.go 0.00% 9 Missing ⚠️
api/build/update.go 0.00% 2 Missing ⚠️

❌ Your project check has failed because the head coverage (58.01%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1441      +/-   ##
==========================================
- Coverage   58.06%   58.01%   -0.06%     
==========================================
  Files         663      663              
  Lines       25564    25588      +24     
==========================================
  Hits        14845    14845              
- Misses      10019    10043      +24     
  Partials      700      700              
Files with missing lines Coverage Δ
api/build/update.go 0.00% <0.00%> (ø)
api/build/auto_cancel.go 32.85% <0.00%> (-4.24%) ⬇️
api/build/cancel.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

plyr4
plyr4 previously approved these changes Apr 15, 2026
@ecrupper ecrupper merged commit 7c39b29 into main Apr 15, 2026
10 of 13 checks passed
@ecrupper ecrupper deleted the fix/allow-cancel-of-orphan branch April 15, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants