Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/native/compile_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import (

"github.com/gin-gonic/gin"
"github.com/google/go-cmp/cmp"
"github.com/google/go-github/v84/github"
"github.com/google/go-github/v85/github"
yml "go.yaml.in/yaml/v3"

api "github.com/go-vela/server/api/types"
Expand Down
2 changes: 1 addition & 1 deletion compiler/registry/github/github.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
"reflect"
"strings"

"github.com/google/go-github/v84/github"
"github.com/google/go-github/v85/github"
"golang.org/x/oauth2"
)

Expand Down
2 changes: 1 addition & 1 deletion compiler/registry/github/github_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (
"testing"

"github.com/google/go-cmp/cmp"
"github.com/google/go-github/v84/github"
"github.com/google/go-github/v85/github"
"golang.org/x/oauth2"
)

Expand Down
2 changes: 1 addition & 1 deletion compiler/registry/github/template.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (
"fmt"
"net/http"

"github.com/google/go-github/v84/github"
"github.com/google/go-github/v85/github"

api "github.com/go-vela/server/api/types"
"github.com/go-vela/server/compiler/registry"
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ require (
github.com/go-playground/assert/v2 v2.2.0
github.com/golang-jwt/jwt/v5 v5.3.1
github.com/google/go-cmp v0.7.0
github.com/google/go-github/v84 v84.0.0
github.com/google/go-github/v85 v85.0.0
github.com/google/uuid v1.6.0
github.com/goware/urlx v0.3.2
github.com/hashicorp/go-cleanhttp v0.5.2
Expand Down
4 changes: 2 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,8 @@ github.com/google/go-cmp v0.2.0/go.mod h1:oXzfMopK8JAjlY9xF4vHSVASa0yLyX7SntLO5a
github.com/google/go-cmp v0.6.0/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY=
github.com/google/go-cmp v0.7.0 h1:wk8382ETsv4JYUZwIsn6YpYiWiBsYLSJiTsyBybVuN8=
github.com/google/go-cmp v0.7.0/go.mod h1:pXiqmnSA92OHEEa9HXL2W4E7lf9JzCmGVUdgjX3N/iU=
github.com/google/go-github/v84 v84.0.0 h1:I/0Xn5IuChMe8TdmI2bbim5nyhaRFJ7DEdzmD2w+yVA=
github.com/google/go-github/v84 v84.0.0/go.mod h1:WwYL1z1ajRdlaPszjVu/47x1L0PXukJBn73xsiYrRRQ=
github.com/google/go-github/v85 v85.0.0 h1:1+TLFX/akTFXK7o9Z9uAloQGufOn4ySa5DItUM1VWT4=
github.com/google/go-github/v85 v85.0.0/go.mod h1:jYkBnqN+SzR2A2fGKYfbt6DEEQAyxeK0Q2XpPV9ZFsU=
github.com/google/go-querystring v1.2.0 h1:yhqkPbu2/OH+V9BfpCVPZkNmUXhb2gBxJArfhIxNtP0=
github.com/google/go-querystring v1.2.0/go.mod h1:8IFJqpSRITyJ8QhQ13bmbeMBDfmeEJZD5A0egEOmkqU=
github.com/google/gofuzz v1.0.0/go.mod h1:dBl0BpW6vV/+mYPU4Po3pmUjxk6FQPldtuIdl/M65Eg=
Expand Down
2 changes: 1 addition & 1 deletion scm/github/access.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
"context"
"strings"

"github.com/google/go-github/v84/github"
"github.com/google/go-github/v85/github"
"github.com/sirupsen/logrus"

api "github.com/go-vela/server/api/types"
Expand Down
2 changes: 1 addition & 1 deletion scm/github/app_permissions.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
"fmt"
"strings"

"github.com/google/go-github/v84/github"
"github.com/google/go-github/v85/github"
)

// see: https://docs.github.com/en/rest/authentication/permissions-required-for-github-apps?apiVersion=2022-11-28
Expand Down
2 changes: 1 addition & 1 deletion scm/github/app_permissions_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ package github
import (
"testing"

"github.com/google/go-github/v84/github"
"github.com/google/go-github/v85/github"
)

func TestGetInstallationPermission(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion scm/github/app_transport.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import (
"time"

"github.com/golang-jwt/jwt/v5"
"github.com/google/go-github/v84/github"
"github.com/google/go-github/v85/github"
"go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace"
"go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp"
)
Expand Down
2 changes: 1 addition & 1 deletion scm/github/authentication.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"net/url"
"strings"

"github.com/google/go-github/v84/github"
"github.com/google/go-github/v85/github"

api "github.com/go-vela/server/api/types"
"github.com/go-vela/server/random"
Expand Down Expand Up @@ -43,7 +43,7 @@
}

// pass through the redirect if it exists
redirect := r.FormValue("redirect_uri")

Check failure on line 46 in scm/github/authentication.go

View workflow job for this annotation

GitHub Actions / full-review

G120: Parsing form data without limiting request body size can allow memory exhaustion (use http.MaxBytesReader) (gosec)

Check failure on line 46 in scm/github/authentication.go

View workflow job for this annotation

GitHub Actions / full-review

G120: Parsing form data without limiting request body size can allow memory exhaustion (use http.MaxBytesReader) (gosec)

Check failure on line 46 in scm/github/authentication.go

View workflow job for this annotation

GitHub Actions / diff-review

G120: Parsing form data without limiting request body size can allow memory exhaustion (use http.MaxBytesReader) (gosec)

Check failure on line 46 in scm/github/authentication.go

View workflow job for this annotation

GitHub Actions / golangci

[golangci] scm/github/authentication.go#L46

G120: Parsing form data without limiting request body size can allow memory exhaustion (use http.MaxBytesReader) (gosec)
Raw output
scm/github/authentication.go:46:25: G120: Parsing form data without limiting request body size can allow memory exhaustion (use http.MaxBytesReader) (gosec)
	redirect := r.FormValue("redirect_uri")
	                       ^
if len(redirect) > 0 {
c.OAuth.RedirectURL = redirect
}
Expand All @@ -60,13 +60,13 @@
c.Logger.Trace("authenticating user")

// get the OAuth code
code := r.FormValue("code")

Check failure on line 63 in scm/github/authentication.go

View workflow job for this annotation

GitHub Actions / full-review

G120: Parsing form data without limiting request body size can allow memory exhaustion (use http.MaxBytesReader) (gosec)

Check failure on line 63 in scm/github/authentication.go

View workflow job for this annotation

GitHub Actions / diff-review

G120: Parsing form data without limiting request body size can allow memory exhaustion (use http.MaxBytesReader) (gosec)

Check failure on line 63 in scm/github/authentication.go

View workflow job for this annotation

GitHub Actions / golangci

[golangci] scm/github/authentication.go#L63

G120: Parsing form data without limiting request body size can allow memory exhaustion (use http.MaxBytesReader) (gosec)
Raw output
scm/github/authentication.go:63:21: G120: Parsing form data without limiting request body size can allow memory exhaustion (use http.MaxBytesReader) (gosec)
	code := r.FormValue("code")
	                   ^
if len(code) == 0 {
return nil, nil
}

// verify the OAuth state
state := r.FormValue("state")

Check failure on line 69 in scm/github/authentication.go

View workflow job for this annotation

GitHub Actions / full-review

G120: Parsing form data without limiting request body size can allow memory exhaustion (use http.MaxBytesReader) (gosec)

Check failure on line 69 in scm/github/authentication.go

View workflow job for this annotation

GitHub Actions / diff-review

G120: Parsing form data without limiting request body size can allow memory exhaustion (use http.MaxBytesReader) (gosec)

Check failure on line 69 in scm/github/authentication.go

View workflow job for this annotation

GitHub Actions / golangci

[golangci] scm/github/authentication.go#L69

G120: Parsing form data without limiting request body size can allow memory exhaustion (use http.MaxBytesReader) (gosec)
Raw output
scm/github/authentication.go:69:22: G120: Parsing form data without limiting request body size can allow memory exhaustion (use http.MaxBytesReader) (gosec)
	state := r.FormValue("state")
	                    ^
6 issues:
* gosec: 6
if state != oAuthState {
return nil, fmt.Errorf("unexpected oauth state: want %s but got %s", oAuthState, state)
}
Expand Down
2 changes: 1 addition & 1 deletion scm/github/changeset.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
"context"
"fmt"

"github.com/google/go-github/v84/github"
"github.com/google/go-github/v85/github"
"github.com/sirupsen/logrus"

api "github.com/go-vela/server/api/types"
Expand Down
2 changes: 1 addition & 1 deletion scm/github/deployment.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
"context"
"encoding/json"

"github.com/google/go-github/v84/github"
"github.com/google/go-github/v85/github"
"github.com/sirupsen/logrus"

api "github.com/go-vela/server/api/types"
Expand Down
2 changes: 1 addition & 1 deletion scm/github/github.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import (
"os"
"strings"

"github.com/google/go-github/v84/github"
"github.com/google/go-github/v85/github"
"github.com/sirupsen/logrus"
"golang.org/x/oauth2"

Expand Down
2 changes: 1 addition & 1 deletion scm/github/github_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
"net/url"
"strings"

"github.com/google/go-github/v84/github"
"github.com/google/go-github/v85/github"
"go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace"
"go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp"
"golang.org/x/oauth2"
Expand Down
2 changes: 1 addition & 1 deletion scm/github/github_client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (
"testing"

"github.com/gin-gonic/gin"
"github.com/google/go-github/v84/github"
"github.com/google/go-github/v85/github"

api "github.com/go-vela/server/api/types"
"github.com/go-vela/server/constants"
Expand Down
2 changes: 1 addition & 1 deletion scm/github/github_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (
"reflect"
"testing"

"github.com/google/go-github/v84/github"
"github.com/google/go-github/v85/github"
"golang.org/x/oauth2"
)

Expand Down
2 changes: 1 addition & 1 deletion scm/github/repo.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (
"strings"
"time"

"github.com/google/go-github/v84/github"
"github.com/google/go-github/v85/github"
"github.com/sirupsen/logrus"

api "github.com/go-vela/server/api/types"
Expand Down
2 changes: 1 addition & 1 deletion scm/github/repo_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import (

"github.com/gin-gonic/gin"
"github.com/google/go-cmp/cmp"
"github.com/google/go-github/v84/github"
"github.com/google/go-github/v85/github"

api "github.com/go-vela/server/api/types"
"github.com/go-vela/server/constants"
Expand Down
2 changes: 1 addition & 1 deletion scm/github/status.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
"strconv"
"strings"

"github.com/google/go-github/v84/github"
"github.com/google/go-github/v85/github"
"github.com/sirupsen/logrus"

api "github.com/go-vela/server/api/types"
Expand Down
2 changes: 1 addition & 1 deletion scm/github/webhook.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import (
"strings"
"time"

"github.com/google/go-github/v84/github"
"github.com/google/go-github/v85/github"
"github.com/sirupsen/logrus"

api "github.com/go-vela/server/api/types"
Expand Down
Loading