Favor strings.Cut to strings.SplitN #57
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is more efficient since it does not allocate an array and just return s if nothing found For the same reason we don't need to use strings.Cut at all if empty
topia
reviewed
Mar 16, 2025
| } | ||
| tagValue = strings.SplitN(tagValue, ",", 2)[0] | ||
| if tagValue != "" { | ||
| tagValue, _, _ = strings.Cut(tagValue, ",") |
There was a problem hiding this comment.
I think this change breaks the behavior of a tag without a name: https://go.dev/play/p/Hu0LR1FDKqi
strings.SplitN or strings.Cut should be out of an if block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is more efficient since it does not allocate an array and just return s if nothing found
For the same reason we don't need to use strings.Cut at all if empty