Fix segmentation fault when adding + 1 to a null pointer #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While upgrading
libosdpfrom version 2.1.0 to 3.0.8, I encountered a segmentation fault. The fault occurred almost immediately upon entering the__cp_setupfunction.Investigation
After analyzing the issue, I traced the problem to the
LOG_PRINTmacro. Specifically, the error originated in the__logger_logfunction, where the return value of thestrrchrfunction was not properly handled.As per the documentation,
strrchrreturns a pointer to the last occurrence of the specified character, or a null pointer if the character is not found. In this case, thefilevariable already contained just the filename (not the full file path), meaning no path separator was present. Consequently,strrchrreturned a null pointer. Adding1to a null pointer caused the segmentation fault.Fix
I updated the code to handle cases where
strrchrreturns a null pointer, ensuring the macro doesn't attempt to dereference or manipulate invalid pointers.