Conversation
- Refactor OuraClient._make_request to handle URL construction centrally - Add logic to ensure endpoints start with / and remove duplicate /v2 prefixes - Update all endpoint modules to use relative paths without /v2 prefix - Update all tests to match new URL construction pattern - All 101 tests passing This fixes issue #8 where URLs were constructed as: https://api.ouraring.com/v2/v2/usercollection/... Now they correctly resolve to: https://api.ouraring.com/v2/usercollection/... 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/v2prefixes in endpoint definitionsOuraClient._make_requestChanges
Updated
OuraClient._make_requestto handle URL construction centrally://v2prefixes if presentRemoved
/v2prefixes from all endpoint modules:/usercollection/...instead of/v2/usercollection/...)Updated all tests to reflect the URL changes:
Test plan
python -m pytest tests/test_client.pyCloses #8
🤖 Generated with Claude Code