Open
Conversation
- I couldn't find an example with "replacing" so I assumed "stopping" was meant. - Moved "Exception:" down to where there is an exception. - Tightened up language about participle adjectives. It's unclear to me whether there's a character limit per line. I kept to under 80 characters. Thank you for your review. I wanted to do something simple for my first pull request, so please let me know how I can improve my process before I venture into open documentation issues.
Should have kept examples at the end to keep relevant text together.
Mickeon
approved these changes
Sep 30, 2025
Member
Mickeon
left a comment
Mickeon
left a comment
There was a problem hiding this comment.
This is an improvement in my opinion, thank you.
Ideally this whole explanation should be rerouted, so as not to mention the Don't sentence in a somewhat awkward spot. These writing guidelines are arguably outdated though, and could use an overall refresher someday.
|
|
||
| You may use the progressive tense to describe actions that are | ||
| continuous in time. Anything like animation or coroutines. | ||
| Exception: You may use the progressive tense to describe actions that are |
Member
There was a problem hiding this comment.
Suggested change
| Exception: You may use the progressive tense to describe actions that are | |
| Exception: You may use the progressive tense to describe actions that are |
| conjugation, so you may use them: ``the remaining movement``, | ||
| ``the missing file``, etc. | ||
| Adding -ing at the end of a verb can turn a noun into an adjective. | ||
| These -ing words are not an example of progressive form, and you may |
Member
There was a problem hiding this comment.
Suggested change
| These -ing words are not an example of progressive form, and you may | |
| These -ing words are not an example of progressive form, and you may |
Member
There was a problem hiding this comment.
Oh, we... could use some static checks for trailing spaces.
Member
There was a problem hiding this comment.
Right, this repo currently doesn't have any static checks. I'll make a note to see if I can copy anything from the docs repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's unclear to me whether there's a character limit per line. I kept to under 80 characters.
Thank you for your review. I wanted to do something simple for my first pull request, so please let me know how I can improve my process before I venture into open documentation issues.