-
-
Notifications
You must be signed in to change notification settings - Fork 677
Cherry-picks for the godot-cpp 4.4 branch - 3rd batch #1836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 646ccdf)
… directory. (cherry picked from commit 1345c46)
(cherry picked from commit 8e7dfbc)
(cherry picked from commit 6a21f76)
Usage of `std::is_trivially_constructible` in `defs.hpp` requires including `type_traits`. This missing include leads to errors about that type not being found when building with clang++-22 with libc++-22. (cherry picked from commit fbe5262)
(cherry picked from commit 9ea9b47)
…r the legacy interface. (cherry picked from commit 05d2ce3)
(cherry picked from commit b192b88)
This is the same as GODOTCPP_SUFFIX but without the leading '.' GODOTCPP_SUFFIX is then based on the above. (cherry picked from commit b64b941)
This was referenced Aug 21, 2025
Merged
Ivorforce
approved these changes
Sep 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested, but I looked through the commits, looks fine to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
This has been identified as a bug
enhancement
This is an enhancement on the current functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 3rd batch of PR's marked with
cherrypick:4.4