Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm looking into converting my module code over to godot-cpp and there are a lot of scons flags that I use in my build system for my module that currently aren't in godot-cpp. I added the one's that I care about here, these are:
linker
flag on linux so I can use mold to link faster.fast_unsafe
flag because it makes incremental rebuilds noticeably faster.I didn't write any of this code either. I just copied it straight from godot's build system. I'm not sure if the way I did it is ideal, like it feels kind of wrong to put
get_compiler_version
method in the linux file but there is no commonmethods.py
file here like there is in the godot build system so I'm not sure where would be the best place to put that.I'd also like to add all of the flags for the sanitizers:
use_ubsan
use_asan
use_lsan
use_tsan
use_msan
In a future PR if possible.