Skip to content

Fix TypedArray source link in Core types #11237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix TypedArray source link in Core types #11237

wants to merge 1 commit into from
+3 −3

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Aug 26, 2025

  • Link PackedArray to variant.h, as this is where its typedefs are located.

@Calinou Calinou force-pushed the core-types-fix-typed-array-link branch from dac387f to aa598d2 Compare August 26, 2025 15:26
@Calinou Calinou added bug area:contributing Issues and PRs related to the Contributing/Development section of the documentation cherrypick:4.4 labels Aug 26, 2025
AThousandShips
AThousandShips approved these changes Aug 26, 2025
View reviewed changes
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably change line 225 to point to https://github.com/godotengine/godot/blob/master/core/variant/typed_dictionary.h as well, otherwise looks good!

@Calinou Calinou changed the title Fix TypedArray source link in Code types Fix TypedArray source link in Core types Aug 26, 2025
@Calinou
Fix TypedArray source link in Core types
c76eaf8 
- Link PackedArray to `variant.h`, as this is where its typedefs are located.
@Calinou Calinou force-pushed the core-types-fix-typed-array-link branch from aa598d2 to c76eaf8 Compare August 26, 2025 16:58
@mhilbrunner mhilbrunner marked this pull request as draft August 27, 2025 21:01
@mhilbrunner
Copy link
Member

Converted to draft because we should probably defer this until #11188

Ivorforce
Ivorforce approved these changes Sep 11, 2025
View reviewed changes
Copy link
Member

@Ivorforce Ivorforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. A rebase auto-move the update to the new location (after #11188).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhilbrunner mhilbrunner mhilbrunner approved these changes

@Ivorforce Ivorforce Ivorforce approved these changes

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
area:contributing Issues and PRs related to the Contributing/Development section of the documentation bug cherrypick:4.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect link to TypedArray C++ header in Core Types documentation
4 participants
@Calinou @mhilbrunner @Ivorforce @AThousandShips