-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[WIP] Add CODEOWNERS #11401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[WIP] Add CODEOWNERS #11401
Conversation
|
Is it necessary to specify Edit: I see you've done right just this at the end of the file, so why doing it for every other line? |
|
It cannot be done once only, unfortunately, it would be great if it worked that way but it doesn't |
.github/CODEOWNERS
Outdated
| /tutorials/export/*ios* @godotengine/ios @godotengine/documentation | ||
| /tutorials/export/*linux* @godotengine/linux-bsd @godotengine/documentation | ||
| /tutorials/export/*macos* @godotengine/macos @godotengine/documentation | ||
| /tutorials/export/*visionos* @godotengine/ios @godotengine/documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There isn't a specific team for this, so unsure what to add here, ownership is also missing from the main repo for this platform
.github/CODEOWNERS
Outdated
|
|
||
| /*.* @godotengine/documentation | ||
|
|
||
| # TODO: Should the build related files, like `.py` be owned by the doc team or buildsystem? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would make them owned by the buildsystem team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then I'll add them and see what cases are relevant, might make the root folder buildsystem and filter more finely for the global assignment for documentation
d38cde6 to
284848a
Compare
|
There cleaned up the formatting and added some new entries, will continue next week! |
284848a to
29a9784
Compare
Several areas missing but as a starting point to figure out the specifics