Skip to content

Conversation

@Ivorforce
Copy link
Member

The changes:

  • The SConstruct file currently lists properties. I don't think this is very useful, because a non-SCons user will not understand how to use this information anyway. Instead, I add a link to the SCons docs.
  • Add more comments to the SConstruct file.
  • Remove .framework logic from SConstruct and .gdextension file. We've figured some months that this wasn't needed (matching godot-cpp-template)
  • Use SHLIBPREFIX along with SHLIBSUFFIX, to remove lib prefix from DLL files (matching godot-cpp-template).
  • Use relative paths for .gdextension files. This makes it possible to rename the folders they are in, leading to fewer problems. It also solves an unfixed hot reload problem on macOS.
  • Removed the dependencies section since it's no longer necessary, add a link to the .gdextension file docs instead.

@Ivorforce Ivorforce force-pushed the godot-cpp-example-sconstruct branch from 47c8295 to edf4390 Compare October 23, 2025 09:34
Copy link
Contributor

@paddy-exe paddy-exe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick, otherwise it looks pretty good 👍🏻

@Ivorforce Ivorforce force-pushed the godot-cpp-example-sconstruct branch from edf4390 to bf09cfd Compare October 23, 2025 18:04
Copy link
Contributor

@paddy-exe paddy-exe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants