Misc fixes and cleanup

[akien-mga]

• Remove the demo project which isn't really useful (had a scene and a script not attached to the scene, and it can't really be used to test committing stuff as that would conflict with the plugin's config).
  • Instead the addons subfolder is made top-level and that's where stuff gets written.
  • Will need to update https://github.com/godotengine/godot-git-plugin/wiki/Git-plugin-v3 too to remove mentions of demo.
• Update the README following recent PRs ([SCons] Build OpenSSL from source. #191, Use OpenSSL on windows too, build libgit2, ssh2 with cmake. #199) as OpenSSL is now compiled from source for all platforms.
  • Also remove obsolete build_openssl_universal_macos.sh script.
• Remove the bogus plugin.cfg which isn't necessary, and was confusing users who tried to enable it.
  • Fixes Godot Git Plugin (4.1+) .gdextension not recognized #267.
• Bump min SCons version to 3.1.2 and Python to 3.6 (similar to Godot on 4.3 - older versions of SCons don't really work with recent Python anymore).
• Bump compatibility_minimum to 4.2.0 following Update plugin for Godot 4.2 due to GDExtension compatibility breakage #196.
• Remove some code in godot-git-plugin/SCsub that seems redundant with godot-cpp config.
• Remove unnecessary .exp and .lib files in Windows artifact, rename its folder to windows.
• Remove export-ignores in .gitattributes, they're incomplete and not actually doing anything usable.
• Fix artifacts URL handling in release.sh, make it executable.
• CI: Update clang-format check to version 18 (last one supported by tagged version of the action we use).

[Faless]

I've actually been working on something similar here (a bit messed up now since it all started while trying to get windows arm builds).

EDIT: I'll give some feedback tomorrow, I think overall your changes are good, but we should probably cleanup a bit more.
In any case, if this works, it's okay to merge, and I can add the other changes on top.

[akien-mga]

Your changes look pretty good, definitely worth going in that direction. The godot-git-plugin folder with a SCsub also bugged me but I opted not to touch it because that looks a bit more complex.

I'm happy to undo some of the changes in this PR to make it more minimal and avoid conflicts with the more comprehensive overhaul you're doing (like the couple removals I made in godot-git-plugin/SCsub aren't critical to do now).

My goal for this PR is just to do a small cleanup before we tag a release with latest OpenSSL for all platforms.

Then we can merge mbedTLS and further refactoring work for the following release.

[akien-mga]

I had to add this awkward step because after removing the demo/ nesting, I ran into an issue with the artifact, where the zip wouldn't contain the addons/ top-level folder.

upload-artifact@v4 doesn't give any way to configure how to zip the given path sadly, so I need to trick it by re-introducing a parent folder to zip the contents of...

Another alternative I considered is to bring back a top-level folder to contain addons (like bin/addons/godot-git-plugin/), but I find it a bit annoying.

[akien-mga]

Well s/bin/out/ because apparently we do have some thirdparty stuff that generates in bin.

[akien-mga]

I tried to download a zip of the repo and noticed we have a .gitattributes that removes source code, but it's outdated.
https://github.com/godotengine/godot-git-plugin/blob/master/.gitattributes

Should probably be removed, we don't store binaries in the repo so there's not much point to try to make a "ready-to-use" zip archive from git.

[akien-mga]

I tested release.sh, had to fix things up a bit as apparently nightly.link can't handle the kind of URLs we now get for artifacts. But it works with just the artifact ID so I'm extracting that.

[Faless]

FYI, for releases, I've adapted (and actually improved) the CI pipeline I'm using for webrtc-native, which uses the download-artifacts actions and produces a packaged godot-git-plugin.zip artifact ready to be uploaded to the release page.

See the pipeline here: https://github.com/Faless/godot-git-plugin/actions/runs/15298595568

[Faless]

I think this is a good starting point, and okay for the OpenSSL release.

I suggest that when we update to mbedTLS we further refactor the build system moving the src folder to the top level.

I would also recommend we start using a pipeline that makes all the builds and package them, making doing releases is much easier (see the above comment, and #291).

[Calinou]

I noticed the .gdextension file contains a reference to arm64 Linux, but no corresponding library is in the artifact:

[configuration]

entry_symbol = "git_plugin_init"
compatibility_minimum = "4.2.0"

[libraries]

linux.editor.x86_64 = "linux/libgit_plugin.linux.editor.x86_64.so"
linux.editor.arm64 = "linux/libgit_plugin.linux.editor.arm64.so"
macos.editor = "macos/libgit_plugin.macos.editor.universal.dylib"
windows.editor.x86_64 = "win64/libgit_plugin.windows.editor.x86_64.dll"

I would probably remove that reference until we add ARM64 to it.

PS: Do we need to include the .exp and .lib files in the Windows artifact? I thought these files were only needed at link-time, not at runtime.

[akien-mga]

I would probably remove that reference until we add ARM64 to it.

Done.

PS: Do we need to include the .exp and .lib files in the Windows artifact? I thought these files were only needed at link-time, not at runtime.

Yeah I don't think those are needed, I pushed an update to remove them.

I also renamed the target folder for Windows libs to windows instead of win64, to be consistent with the linux and macos ones.

[Calinou]

Looks good to me.