Added auto-detection of VSCodium in complement of VSCode#98
Open
chsxf wants to merge 1 commit intogodotlauncher:mainfrom
Open
Added auto-detection of VSCodium in complement of VSCode#98chsxf wants to merge 1 commit intogodotlauncher:mainfrom
chsxf wants to merge 1 commit intogodotlauncher:mainfrom
Conversation
391ff9b to
97dbd22
Compare
97dbd22 to
4921f9f
Compare
Contributor
Author
|
@mariodebono Sorry for not noticing earlier that you're the maintainer of the launcher. As your theme extension is not available on OpenVSX, I had to add another one. If you make it available on OpenVSX, we can revert that part. |
Contributor
|
Hi @chsxf , thanks for your contribution. |
Contributor
|
@chsxf regarding the theme extension, feel free to hop on Discord for a discussion if you are interested in collaborating |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VSCodium is a drop-in replacement for Visual Studio Code if you want to get rid of all VSCode telemetry and remote monitoring.
I think a FOSS project like the Godot Launcher should support it.
In order for this to work, I've done the following things:
Added the various paths where VSCodium is generally found, pretty much matching those of VSCode
Slightly reorganized the extension list to make sure the extensions available on OpenVSX are listed first. It seems there is a bug within VSCode/VSCodium for the recommendation list. Only the first available extensions are displayed. As soon as the list hits an extension that is not available, the following extensions won't be displayed, even if available.
Modified the translations in English and French