Added a clear example of the formatting#108
Open
aop wants to merge 1 commit intogoecharger:masterfrom
Open
Conversation
Changed the method to describe the fact that the HTTP method should be GET (even though the non-standard SET seems to work as well). Also added an example clearing out how the payload should be input. Update go-eCharger API v1 EN.md
syssi
reviewed
Aug 13, 2022
|
|
||
| For example setting the Ampere value for the PWM signaling to the value of "8" would be a | ||
|
|
||
| ```GET http://192.168.4.1/mqtt?payload=amp=8``` |
There was a problem hiding this comment.
This doesn't look like valid query string. Is the second (non URL encoded) = correct?
Author
There was a problem hiding this comment.
You're probably right. I was using Postman to test out the request and that worked just fine so I'd assume that some encoding is happening in the background, or then this just works for some reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the method to describe the fact that the HTTP method should be GET (even though the non-standard SET seems to work as well).
Also added an example clearing out how the payload should be input.