Debugged the responsive issue in mobile view#5
Open
sana070 wants to merge 1 commit intogogurgaon:masterfrom
Open
Debugged the responsive issue in mobile view#5sana070 wants to merge 1 commit intogogurgaon:masterfrom
sana070 wants to merge 1 commit intogogurgaon:masterfrom
Conversation
Member
|
@sana070 The desktop view shouldn't be affected. The changes you have made for responsive view has changed it a bit. Could you restore it? And a good thumb rule for making views responsive is to achieve it without scrolling. You could try using Flexbox https://envato.com/blog/css3-flexbox/ |
Member
|
Try to make the flow vertical without horizontal scrolling |
Member
|
Apart from the changes. Nicely done 👍 . Just try to work on the changes I suggested |
Author
|
yea sure I ll try doing it..
…On Mon, Feb 4, 2019 at 10:32 PM Anwesh Nayak ***@***.***> wrote:
Apart from the changes. Nicely done 👍 . Just try to work on the changes
I suggested
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ArgmjwSWPF2O5k2Qk-eZq5a0YkDk12nsks5vKGewgaJpZM4aejaX>
.
|
Contributor
|
Hi @sana070, thanks for the patch! Do you need any help? These changes LGTM. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey
I have debugged the issue to make UI responsive mobile devices#1..
Have a look..