Add proposal for identity aware proxy authentication mode#233
Open
shengjiang3 wants to merge 3 commits intogoharbor:mainfrom
Open
Add proposal for identity aware proxy authentication mode#233shengjiang3 wants to merge 3 commits intogoharbor:mainfrom
shengjiang3 wants to merge 3 commits intogoharbor:mainfrom
Conversation
Vad1mo
approved these changes
Oct 20, 2023
Member
Vad1mo
left a comment
Vad1mo
left a comment
There was a problem hiding this comment.
makes sense to me, IMO, there are many companies out there that are doing it.
I think what would help the proposal to get approval is:
- Highlight use cases where OIDC isn't possible
- Highlight use cases and integration options that would become possible with that. (the k8s one is good step, but I am sure there are more)
Member
|
@shengjiang3 can you fix DCO please |
Adds a proposal for identity aware proxy authentication mode in Harbor. Signed-off-by: Sheng Jiang <sheng.jiang3@gmail.com>
Adds a proposal for identity aware proxy authentication mode in Harbor. Signed-off-by: Sheng Jiang <sheng.jiang3@gmail.com>
- Added a section for where OIDC is not possible. - Added a section for integration and use case. Signed-off-by: Sheng Jiang <sheng.jiang3@gmail.com>
wy65701436
assigned
stonezdj,
wy65701436 and
chlins and unassigned
OrlinVasilev,
chlins and
MinerYang
stonezdj
requested changes
Jan 29, 2024
Contributor
stonezdj
left a comment
stonezdj
left a comment
There was a problem hiding this comment.
Could you please add more detail for the implementation? such as the configuration item and give some brief introductions to the key change to implement it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a proposal for the Identity Aware proxy authentication mode. The identity aware proxy authentication mode is intended for Harbor to verify and use the identity token from an upstream identity proxy for the user identity.