Skip to content

Conversation

@adityachopra29
Copy link
Contributor

@adityachopra29 adityachopra29 commented Jan 25, 2026

Overview

Changes made

  • Creates a new workflow (harbor-e2e) which setups Harbor instance and integrated into default workflow
  • Uses the repo https://github.com/bupd/harbor-podman, but is modified to be use for non SELinux such as Ubuntu (since github actions runner prefer ubuntu)
  • Modifies the e2e tests to use the local harbor instance endpoints, and have demo.goharbor.io as fallback

Testing

  • All changes are tested and are working on the CI succesfully (check CI)

Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
@adityachopra29 adityachopra29 marked this pull request as draft January 25, 2026 14:38
@codecov
Copy link

codecov bot commented Jan 25, 2026

Codecov Report

❌ Patch coverage is 0% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 7.15%. Comparing base (60ad0bd) to head (ea00ba7).
⚠️ Report is 81 commits behind head on main.

Files with missing lines Patch % Lines
test/helper/helpers.go 0.00% 44 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             main    #648      +/-   ##
=========================================
- Coverage   10.99%   7.15%   -3.84%     
=========================================
  Files         173     260      +87     
  Lines        8671   12891    +4220     
=========================================
- Hits          953     922      -31     
- Misses       7612   11861    +4249     
- Partials      106     108       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…bor endpoints

Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
@adityachopra29 adityachopra29 force-pushed the feat/harbor-setup-podman branch from aaa46c9 to a55b3a6 Compare January 25, 2026 15:43
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
@adityachopra29 adityachopra29 marked this pull request as ready for review January 25, 2026 20:42
Timeout: 5 * time.Second,
Transport: &http.Transport{
TLSClientConfig: &tls.Config{
InsecureSkipVerify: true, // #nosec G402 - Allow self-signed certs for local test instance only
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note : Since we are using a local harbor setup using a self-signed certificate, and this helper function is used for it only, it was necessary to add this directive here (to mute lint error).

@adityachopra29
Copy link
Contributor Author

Hi @bupd @Vad1mo, This PR is ready for review, PTAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make tests not Dependent on Demo Server

1 participant