fix: add missing error returns in command handlers #656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several commands were logging errors with log.Errorf() but continuing execution instead of returning the error. This caused commands to silently fail and proceed with invalid/empty values. Fixed files: - cmd/harbor/root/artifact/delete.go - cmd/harbor/root/artifact/scan.go - cmd/harbor/root/artifact/tags.go - cmd/harbor/root/artifact/view.go - cmd/harbor/root/repository/delete.go Changes: - Convert Run to RunE for proper error handling - Replace log.Errorf() with return fmt.Errorf() to propagate errors - Remove unused log imports Signed-off-by: Anvay <anvaykharb007@gmail.com>
Author
|
please review @bupd |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #656 +/- ##
=========================================
- Coverage 10.99% 7.17% -3.82%
=========================================
Files 173 260 +87
Lines 8671 12845 +4174
=========================================
- Hits 953 922 -31
- Misses 7612 11815 +4203
- Partials 106 108 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #455
This pull request fixes a recurring issue in the CLI where errors were being logged but execution continued as if nothing went wrong. In several commands, log.Errorf() was used without returning the error, which caused the CLI to proceed with invalid or empty values and fail silently.
To address this, the PR replaces error logging with explicit error returns using fmt.Errorf, ensuring that failures immediately stop execution and are correctly surfaced to the user. To support this flow, affected commands were updated to use Cobra’s RunE instead of Run, which is the recommended pattern when commands can fail.
As part of this cleanup, the unused logrus imports were removed from the affected files, since error reporting is now handled through returned errors rather than logging.
Overall, this change makes CLI behavior more predictable, prevents silent failures, and aligns error handling across commands with standard Cobra and Go best practices.