feat: Check Hugo installed hugo version before serve#600
Open
bupd wants to merge 1 commit intogoharbor:mainfrom
Open
feat: Check Hugo installed hugo version before serve#600bupd wants to merge 1 commit intogoharbor:mainfrom
bupd wants to merge 1 commit intogoharbor:mainfrom
Conversation
* Adds checking of current hugo version installed * checks the current hugo version installed and verifies if the correct hugo version required is installed before serve. * adds .tool-versions to gitignore - an autogenerated file by asdf. Signed-off-by: bupd <bupdprasanth@gmail.com>
Member
|
hi @bupd thanks for the PR, is that required by some issue that you have faced or ? |
Contributor
Author
|
Yes, I have updated the description @OrlinVasilev |
Vad1mo
approved these changes
Dec 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TLDR; We need better error message when our local hugo version is wrong.
Changes made
serve.tool-versionsto.gitignoreto exclude asdf-managed version fileDescription
I’ve seen a recurring issue that wastes a lot of time when working on multiple OSS projects with different Hugo versions. Often, the app doesn’t compile correctly, and instead of a clear error, we get misleading messages. This leads to a frustrating cycle of fixing one error only to encounter another, sometimes wasting 40-70 minutes before realizing the issue is simply using the wrong version of Hugo.
Here's a screenshot of the misleading error caused by the wrong Hugo version: (misleading right).
the error messages doesn't clearly mention the correct version to use.