Implemented dark mode in harbor website#703
Open
mythicalyash wants to merge 2 commits intogoharbor:mainfrom
Open
Implemented dark mode in harbor website#703mythicalyash wants to merge 2 commits intogoharbor:mainfrom
mythicalyash wants to merge 2 commits intogoharbor:mainfrom
Conversation
Signed-off-by: mythicalyash <21yashvardhan22@gmail.com>
Member
|
Hi @mythicalyash thanks for the contribution! Looks legit to me |
OrlinVasilev
requested changes
Feb 2, 2026
| {{ if $home }} | ||
| <script async defer src="https://buttons.github.io/buttons.js"></script> | ||
| {{ end }} | ||
| <!-- Analytics --> |
Member
There was a problem hiding this comment.
why do you remove this line?
Author
There was a problem hiding this comment.
Must be Error
I will restore this
Thanks for pointing it out
Author
Most of work was done by me |
Signed-off-by: Yashvardhan <122466420+mythicalyash@users.noreply.github.com>
Author
|
@OrlinVasilev |
Member
|
great stuff thanks! |
Author
welcome |
Author
|
@Vad1mo can you review this ? |
OrlinVasilev
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces full dark mode support to the Harbor website, including a user-controlled theme toggle, automatic system preference detection, persistent theme selection, and flash-of-unstyled-content (FOUC) prevention. The implementation is accessible, performant, and visually consistent with the existing design system.
🚀 Changes Made
➕ New Files
assets/sass/dark-mode.sassComplete dark mode styling using CSS custom properties.
layouts/partials/theme-toggle.htmlAlpine.js–powered theme toggle component with accessibility support.
✏️ Modified Files
layouts/_default/baseof.htmllayouts/partials/navbar.htmlassets/sass/style.sass✅ Features Implemented
Theme Toggle Button
System Preference Detection
prefers-color-schemeon first visitPersistent Theme Selection
localStorageFOUC Prevention
Comprehensive Dark Mode Styling
Fully styled components:
Proper contrast and visual hierarchy
White text on colored buttons for readability
🎨 Visual Overview
Light Mode (unchanged)
Dark Mode
#1a1a1a)#000000) for contrast#e0e0e0) with white headings🧪 Testing Performed
♿ Accessibility