Skip to content

vscode-go: add option to disable tool recompilation prompts #3728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −2
Open

vscode-go: add option to disable tool recompilation prompts #3728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion extension/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1558,6 +1558,12 @@
"description": "Automatically update the tools used by the extension, without prompting the user.",
"scope": "resource"
},
"go.toolsManagement.warnOutdated": {
"type": "boolean",
"default": true,
"description": "Warn the user if the tools used by the extension appear outdated, or are not regular Go binaries. This has no effect if `go.toolsManagement.autoUpdate` is true.",
"scope": "resource"
},
"go.enableCodeLens": {
"type": "object",
"properties": {
Expand Down Expand Up @@ -2852,4 +2858,4 @@
}
]
}
}
}
2 changes: 1 addition & 1 deletion extension/src/goInstallTools.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,7 +822,7 @@ export async function suggestUpdates() {
const toolsManagementConfig = getGoConfig()['toolsManagement'];
if (toolsManagementConfig && toolsManagementConfig['autoUpdate'] === true) {
installTools(toolsToUpdate, configuredGoVersion, { silent: true });
} else {
} else if (toolsManagementConfig && toolsManagementConfig['warnOutdated'] === true) {
const updateToolsCmdText = 'Update tools';
const selected = await vscode.window.showWarningMessage(
`Tools (${toolsToUpdate.map((tool) => tool.name).join(', ')}) need recompiling to work with ${
Expand Down