build(deps): bump github.com/bombsimon/wsl/v5 from 4.7.0 to 5.0.0 #5900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Fernandez Ludovic <ldez@users.noreply.github.com>
|
|
ldez
added
dependencies
ldez
changed the title
wsl_v5, new major version of wsl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to discussion outside of GitHub we've decided that new major versions should be added as new linters using
WithVersionto avoid breaking changes.This will add the full rewrite of
wslaswsl_v5. This will make most sense since even though the rules are the same, everything around configuration and diagnostics is change. The reports now have different syntax so any previous exclusions won't have any effect. Further there's no obvious mapping between old and new config, however there are conversions that can be made that will be added in a future PR.