Skip to content

Conversation

gogolok
Copy link
Contributor

@gogolok gogolok commented Oct 12, 2025

This unblocks goreleaser from creating a freebsd/arm64 binary. I'm not sure why it has been blocked since golangci-lint is working fine on FreeBSD arm64/AArch64 when built manually.

Also, while here, adjust the install.sh script to support freebsd/arm64.

There is already a FreeBSD port of golangci-lint available at devel/golangci-lint and the builds for arm64 seem to look fine.

Copy link

boring-cyborg bot commented Oct 12, 2025

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Oct 12, 2025

CLA assistant check
All committers have signed the CLA.

@ldez ldez changed the title Add support for generating freebsd/arm64 targeted builds chore: freebsd/arm64 builds Oct 12, 2025
@ldez ldez added the area: install Issue relates to installation or downloading process label Oct 12, 2025
@ldez ldez self-requested a review October 12, 2025 23:42
@ldez
Copy link
Member

ldez commented Oct 12, 2025

Could you add a description? Maybe with some references.

You also need to sign the CLA

@ldez ldez added the waiting for: contributor feedback Requires additional feedback label Oct 12, 2025
@ldez
Copy link
Member

ldez commented Oct 13, 2025

I noticed that you are working for StackIT.

I sent an email to your company on 2025-05-14 (I used the email from GitHub organization profile), but I didn't receive any response.

Do you have a contact to share? You can use the email from our GitHub profile

@ldez
Copy link
Member

ldez commented Oct 13, 2025

The exclusion of freebsd/arm64 was not documented.

There is only a commit, no related PR.

But this commit happens during go1.13, and freebsd/arm64 was added in go1.14.

Go now supports the 64-bit ARM architecture on FreeBSD 12.0 or later (the freebsd/arm64 port).
https://tip.golang.org/doc/go1.14#freebsd

@ldez ldez added enhancement New feature or improvement and removed waiting for: contributor feedback Requires additional feedback labels Oct 13, 2025
@ldez ldez added this to the unreleased milestone Oct 13, 2025
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit 870ddc1 into golangci:main Oct 13, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: install Issue relates to installation or downloading process enhancement New feature or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants