fix issue #304 fallback for bad wikipedia.org title suggestion

[hobson]

• Fix "Creatity page not found" when retrieving page for "Creativity" #304
• Fallback to original title if wikipedia.org suggest API returns a nonexistent page title or no suggestions
• Add BAD SUGGESTION warnings when Wikipedia.org suggests nonexsitent titles

[wlerin]

Not a contributor/maintainer, but that has way too many formatting changes to tell what you actually changed.

Edit: After some searching around and looking at the expected locations to be changed, I really don't see the point of this. The main problem isn't that suggestion sometimes (nearly always) returns bonkers "suggestions", it's that those take precedence over actual pages. A library that is meant to be incorporated into other programs (some of them non-interactive) spewing out a bunch of capital letters won't fix that.

[theptrk]

Someone should just make a PR that changes that priority.

Its right here:

Wikipedia/wikipedia/wikipedia.py

Line 272 in 1554943

title = suggestion or results[0]

    if auto_suggest:
      results, suggestion = search(title, results=1, suggestion=True)
      try:
        title = suggestion or results[0]
      except IndexError:
        # if there is no suggestion or search results, the page doesn't exist
        raise PageError(title)