fix SNI wildcard matching #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code is using fnmatch(3) which allows a wildcard to match multiple DNS labels. e.g. *.domain.tld matches foo.bar.domain.tld. This is incorrect. According to the RFC a wildcard can at most match one DNS label (only bar.domain.tld in the example above). For OpenSSL 1.0.2 and above we make use of X509_check_host(). For older versions we check the left most DNS label only, which is the same Apache currently supports.
manuelm
force-pushed
the
stage_for_upstream/v2.8a
branch
from
3492fe3 to
9ed3aa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code is using fnmatch(3) which allows a wildcard to match
multiple DNS labels. e.g. *.domain.tld matches foo.bar.domain.tld. This
is incorrect. According to the RFC a wildcard can at most match one DNS
label (only bar.domain.tld in the example above).
For OpenSSL 1.0.2 and above we make use of X509_check_host(). For older
versions we check the left most DNS label only, which is the same Apache
currently supports.