Clean up client.rb #24

goofmint · 2017-05-19T05:44:06Z

No description provided.

goofmint · 2017-05-19T05:44:12Z

examples/data_store.rb

  item.set('Boolean', true)
  item.set('Array', [i, i * 2, i * 3, 'Orange', 'Tomato'])
-  item.set('Object', {test1: 'a', test2: 'b'})
+  item.set('Object', { test1: 'a', test2: 'b' })


[rubocop]

Redundant curly braces around a hash parameter.

goofmint · 2017-05-19T05:44:12Z

examples/data_store.rb

-# @todo = @todo.limit(20).inArray("Array", [4])
-# @todo = @todo.limit(20).notInArray("Array", ['Orange'])
-# @todo = @todo.limit(20).allInArray("Array", [1, 2, 4])
+=begin


[rubocop]

Do not use block comments. :ref

Use only ascii symbols in comments. :ref

goofmint · 2017-05-19T05:44:12Z

examples/data_store.rb

-# @todo = @todo.limit(20).notInArray("Array", ['Orange'])
-# @todo = @todo.limit(20).allInArray("Array", [1, 2, 4])
+=begin
+@todo = @todo.limit(20).where("String", 'テスト100').greaterThan("Integer", 1)


[rubocop]

Use only ascii symbols in comments. :ref

goofmint · 2017-05-19T05:44:13Z

examples/data_store.rb

-# @todo = @todo.limit(20).allInArray("Array", [1, 2, 4])
+=begin
+@todo = @todo.limit(20).where("String", 'テスト100').greaterThan("Integer", 1)
+@todo = @todo.limit(20).notEqualTo("String", 'テスト100')


[rubocop]

Use only ascii symbols in comments. :ref

goofmint · 2017-05-19T05:44:13Z

examples/data_store.rb

+=begin
+@todo = @todo.limit(20).where("String", 'テスト100').greaterThan("Integer", 1)
+@todo = @todo.limit(20).notEqualTo("String", 'テスト100')
+@todo = @todo.limit(20).in("String", ['テスト100'])


[rubocop]

Use only ascii symbols in comments. :ref

goofmint · 2017-05-19T05:44:13Z

examples/signature.rb

-      testKey: 'testValue'
-    }
-  }
+  { where: {


[rubocop]

Redundant curly braces around a hash parameter.

goofmint · 2017-05-19T05:44:13Z

examples/signature.rb

-  }
+  { where: {
+    testKey: 'testValue'
+  }}


[rubocop]

Space inside } missing. :ref

goofmint · 2017-05-19T05:44:14Z

examples/performance.rb

      item.set('Boolean', true)
      item.set('Array', [i, i * 2, i * 3, 'Orange', 'Tomato'])
-      item.set('Object', {test1: 'a', test2: 'b'})
+      item.set('Object', { test1: 'a', test2: 'b' })


[rubocop]

Redundant curly braces around a hash parameter.

goofmint · 2017-05-19T05:44:14Z

lib/ncmb/object.rb

+
    def deletable?
-      if self.acl['*'.to_sym][:write] == true
+      if acl['*'.to_sym][:write] == true


[rubocop]

Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||. :ref

goofmint · 2017-05-19T05:44:14Z

lib/ncmb/object.rb

    end
-    alias :update :put
-    
+    alias update put


[rubocop]

Use a guard clause instead of wrapping the code inside a conditional expression. :ref

goofmint · 2017-05-19T05:44:14Z

lib/ncmb/client.rb

      queries.each do |k, v|
        v = array2hash(v) if v.is_a? Array
-        value = URI.encode(v.is_a?(Hash) ? v.to_json : v.to_s).gsub("[", "%5B").gsub(":", "%3A").gsub("]", "%5D")
+        value = URI.encode(v.is_a?(Hash) ? v.to_json : v.to_s).gsub('[', '%5B').gsub(':', '%3A').gsub(']', '%5D')


[rubocop]

Line is too long. [113/80] :ref

goofmint · 2017-05-19T05:44:15Z

lib/ncmb/client.rb

      signature_base << @domain
      signature_base << path
-      signature_base << params.collect{|k,v| "#{k}=#{v}"}.join("&")
+      signature_base << params.collect{|k,v| "#{k}=#{v}"}.join('&')


[rubocop]

Space missing to the left of {.

Space between { and | missing.

Space missing after comma. :ref

Space missing inside }.

goofmint · 2017-05-19T05:44:15Z

lib/ncmb/client.rb

            "#{key}=#{value}"
          end.join("&")
-          path = path + (query == '' ? "" : "?"+query)
+          path = path + (query == '' ? '' : "?"+query)


[rubocop]

Use self-assignment shorthand +=. :ref

Prefer single-quoted strings when you don't need string interpolation or special symbols. :ref

Surrounding space missing for operator +. :ref

goofmint · 2017-05-19T05:44:15Z

lib/ncmb/client.rb

            boundary = SecureRandom.uuid
            req.body = make_boundary(boundary, queries)
-            headers["Content-Type"] = "multipart/form-data; boundary=#{boundary}"
+            headers['Content-Type'] = "multipart/form-data; boundary=#{boundary}"


[rubocop]

Line is too long. [81/80] :ref

goofmint · 2017-05-19T05:44:16Z

lib/ncmb/client.rb

            boundary = SecureRandom.uuid
            req.body = make_boundary(boundary, queries)
-            headers["Content-Type"] = "multipart/form-data; boundary=#{boundary}"
+            headers['Content-Type'] = "multipart/form-data; boundary=#{boundary}"


[rubocop]

Line is too long. [81/80] :ref

goofmint · 2017-05-19T06:02:19Z

lib/ncmb/client.rb

        end
      end
-      new_v = new_v.sort_by{|a, b| a.to_s}.to_h
+      new_v = new_v.sort_by{ |a, b| a.to_s }.to_h


[rubocop]

Space missing to the left of {.

Unused block argument - b. If it's necessary, use _ or _b as an argument name to indicate that it won't be used. :ref

goofmint · 2017-05-19T06:02:20Z

lib/ncmb/client.rb

        v = array2hash(v) if v.is_a? Array
-        value = URI.encode(v.is_a?(Hash) ? v.to_json : v.to_s).gsub("[", "%5B").gsub(":", "%3A").gsub("]", "%5D")
+        value = URI.encode(v.is_a?(Hash) ? v.to_json : v.to_s)
+          .encode("UTF-8")


[rubocop]

Align .encode with .encode on line 63.

Prefer single-quoted strings when you don't need string interpolation or special symbols. :ref

goofmint · 2017-05-19T06:02:20Z

lib/ncmb/client.rb

-        value = URI.encode(v.is_a?(Hash) ? v.to_json : v.to_s).gsub("[", "%5B").gsub(":", "%3A").gsub("]", "%5D")
+        value = URI.encode(v.is_a?(Hash) ? v.to_json : v.to_s)
+          .encode("UTF-8")
+          .gsub('[', '%5B')


[rubocop]

Align .gsub with .encode on line 63.

goofmint · 2017-05-19T06:02:20Z

lib/ncmb/client.rb

+        value = URI.encode(v.is_a?(Hash) ? v.to_json : v.to_s)
+          .encode("UTF-8")
+          .gsub('[', '%5B')
+          .gsub(':', '%3A')


[rubocop]

Align .gsub with .encode on line 63.

goofmint · 2017-05-19T06:02:20Z

lib/ncmb/client.rb

+          .encode("UTF-8")
+          .gsub('[', '%5B')
+          .gsub(':', '%3A')
+          .gsub(']', '%5D')


[rubocop]

Align .gsub with .encode on line 63.

goofmint · 2017-05-19T06:02:21Z

lib/ncmb/client.rb

-        params = params.sort_by{|a, b| a.to_s}.to_h
+      params = params.merge 'X-NCMB-Timestamp' => now
+      if [].respond_to?('to_h') # Array#to_h inpremented over ruby 2.1
+        params = params.sort_by { |a, b| a.to_s }.to_h


[rubocop]

Unused block argument - b. If it's necessary, use _ or _b as an argument name to indicate that it won't be used. :ref

goofmint · 2017-05-19T06:02:21Z

lib/ncmb/client.rb

      else
        sorted_params = {}
-        params = params.sort_by{|a, b| a.to_s}.each {|kv|
+        params = params.sort_by { |a, b| a.to_s }.each { |kv|


[rubocop]

Useless assignment to variable - params. :ref

Unused block argument - b. If it's necessary, use _ or _b as an argument name to indicate that it won't be used. :ref

Avoid using {...} for multi-line blocks. :ref

goofmint · 2017-05-19T06:02:21Z

lib/ncmb/client.rb

+      signature_base << params.collect { |k, v| "#{k}=#{v}" }.join('&')
+      Base64.encode64(
+        OpenSSL::HMAC.digest(OpenSSL::Digest.new('sha256'),
+        @client_key,


[rubocop]

Align the parameters of a method call if they span more than one line. :ref

goofmint · 2017-05-19T06:02:21Z

lib/ncmb/client.rb

+      Base64.encode64(
+        OpenSSL::HMAC.digest(OpenSSL::Digest.new('sha256'),
+        @client_key,
+        signature_base.join("\n"))


[rubocop]

Align the parameters of a method call if they span more than one line. :ref

goofmint · 2017-05-19T06:02:22Z

Click here if you want to create rubocop's auto-correct Pull Request

See the documentation if you want to get more information about auto-correct.
Document

goofmint · 2017-05-19T06:02:22Z

lib/ncmb/client.rb

            json = http.get(path, headers).body
          else
-            json = JSON.parse(http.get(path, headers).body, symbolize_names: true)
+            json = JSON.parse(


[rubocop]

Use 2 (not -5) spaces for indentation. :ref

goofmint · 2017-05-19T06:02:22Z

lib/ncmb/client.rb

        end
      rescue => e
-        @@last_error =  e
+        @@last_error = e


[rubocop]

Replace class var @@last_error with a class instance var. :ref

Clean up client.rb

dc331f6

goofmint commented May 19, 2017

View reviewed changes

examples/signature.rb

testKey: 'testValue'

}

}

{ where: {

Copy link

Owner Author

goofmint May 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[rubocop]

Redundant curly braces around a hash parameter.

goofmint commented May 19, 2017

View reviewed changes

examples/signature.rb

}

{ where: {

testKey: 'testValue'

}}

Copy link

Owner Author

goofmint May 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[rubocop]

Space inside } missing. :ref

goofmint commented May 19, 2017

View reviewed changes

Clean up client.rb

faad435

goofmint commented May 19, 2017

View reviewed changes

Clean up client.rb #24

Are you sure you want to change the base?

Clean up client.rb #24

Uh oh!

Conversation

goofmint commented May 19, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

goofmint commented May 19, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants