BUGFIX: Unpin tensorflow_datasets#241
BUGFIX: Unpin tensorflow_datasets#241ethanluoyc wants to merge 1 commit intogoogle-deepmind:masterfrom
Conversation
The current pinned version does not work for some of the d4rl locomotion v2 datasets due to the wrong specification in metadata types.
|
Not sure what the tests failure are about tho. |
|
We use specific versions of packages to make sure new releases of dependencies don't break things at a random (which happens a number of times). Could you use specific version which solves the problem? |
I understand that Reverb and Launchpad depend on the ABI of exact versions of tensorflow, so it is important to pin the versions of lp and reverb against a specific version to make sure that users do not accidentally install versions that break. In this case, however, I think tf-datasets does not have any C++ extensions (the C++ extensions for tf.data are in core tensorflow, not tf-datasets), so I think it is unnecessary to pin the tf-dataset version :) In general, I would suggest that we should make requirements in setup.py more flexible. Pinning the dependencies in the way it is makes the life of users who depend on Acme as a library very difficult: there is no freedom in choosing the version of the dependencies that Acme should use. pip will throw an error when I try to install dm-acme with an alternative version of tf-datasets as it is unable to find compatible versions that satisfy the constraints. I am happy to create a PR to help set up a more flexible way to manage dependencies and I believe that users outside DM can benefit a lot from this. |
The current pinned version does not work for some of the d4rl locomotion v2 datasets due to the wrong specification in metadata types.