Fix robustness issue from relative paths in download script #1115
+11
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when users run the download script with a relative path, the extraction steps for datasets such as mgnify, small_bfd, uniprot, and uniref90 may fail. The issue is not caused by the
pushd/popdusage itself, but rather by the lack of normalization of user-provided paths.This patch converts the user-supplied download path into an absolute path before use, which resolves the issue and avoids unexpected directory-related failures.
This problem has been mentioned in multiple issues and pull requests, for example issue #722 and pull request #1024.
Your review and consideration for merging this change would be appreciated.