Cleanup clopper-pearson all thresholds logic and fix one-run loop condition. #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_850109858
branch
from
2c70967 to
8412fd8
Compare
…dition. The previous loop condition could conceivably terminate early because the search is in order of precision lower bound, not raw precision. Continue instead of break is correct and fast enough. PiperOrigin-RevId: 850155884
copybara-service
bot
force-pushed
the
test_850109858
branch
from
8412fd8 to
58a574f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup clopper-pearson all thresholds logic and fix one-run loop condition.
The previous loop condition could conceivably terminate early because the search is in order of precision lower bound, not raw precision. Continue instead of break is correct and fast enough.