Remove TensorFlow dependency and migrate mlp_mnist to Flax NNX #1536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vroulet
reviewed
Dec 26, 2025
| "from flax import nnx\n", | ||
| "\n", | ||
| "import grain.python as pygrain\n", | ||
| "from torchvision.datasets import MNIST\n", |
Collaborator
There was a problem hiding this comment.
Why are we using torchvision? Would be best to have either only grain or grain and tensorflow-datasets (if possible avoid tensorflow because of versioning issues).
Collaborator
There was a problem hiding this comment.
torchvision as a source for the dataset might be correct as it's a widely used and a well maintained package. This also show that optax (and jax) can be highly interoperable with the existing ecosystem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
TensorFlowdependency from themlp_mnistnotebook and updates the code to use Flax NNX instead offlax.linen.It also transitions the data loading pipeline to usegrain, aligning the example with modern JAX best practices.