Add expert choice routing mode to MoEFeedForward#8
Open
ahmedtaha100 wants to merge 1 commit intogoogle-deepmind:mainfrom
Open
Add expert choice routing mode to MoEFeedForward#8ahmedtaha100 wants to merge 1 commit intogoogle-deepmind:mainfrom
ahmedtaha100 wants to merge 1 commit intogoogle-deepmind:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
I just applied for the google CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add expert-choice routing mode for MoEFeedForward
Adds expert-choice routing (Zhou et al., 2022) where each expert selectsits top-C tokens, providing natural load balancing without auxiliary losses.
Changes
model_lib.py:routing_modefield,_apply_expert_choice_moe(),restructuredapply()with early routing-mode branchconfig_lib.py:routing_modeinBaseExperimentConfig,lm_moe_testandlm_moe_expert_choice_testconfigsmodel_lib_test.py:simple_expert_choice_moe()reference impl,forward/gradient equivalence testsHow to test
# Expert-choice MoE local testpython -m simply.main --experiment_config lm_moe_expert_choice_test --experiment_dir /tmp/moe_ec_test --alsologtostderr# All MoE unit tests (including existing + new)pytest simply/model_lib_test.py::MoETest -vDesign decisions
_apply_dense_moedispatch pattern (einsums, not sparse GMM)lbl_lossis skipped whenrouting_mode='expert_choice'(load isbalanced by construction, so the auxiliary loss is unnecessary)routing_modeis validated; unknown values raiseValueErrorsimple_moe()equivalence tests pass with the same tolerances as before