Skip to content

Add prompt feedback check for candidates blocked due to safety.#115

Merged
wt17 merged 2 commits intomainfrom
block-reason
Mar 23, 2026
Merged

Add prompt feedback check for candidates blocked due to safety.#115
wt17 merged 2 commits intomainfrom
block-reason

Conversation

@wt17
Copy link
Copy Markdown
Collaborator

@wt17 wt17 commented Mar 20, 2026

No description provided.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the agent's error handling by specifically checking for and reporting safety-related blocks in the response. This ensures that if a response is blocked due to safety concerns, a more informative error is raised, aiding in debugging and maintaining safety standards.

Highlights

  • Safety Check: Added a check to raise an error if the response is blocked due to safety concerns, specifically when response.prompt_feedback.block_reason.name is 'SAFETY'.
  • Error Handling: Improved error handling for responses with no candidates by checking for safety blocks before raising a general 'Empty response' error.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a check to handle responses that are blocked due to safety filters, which is a valuable addition. My review includes a suggestion to make this implementation more robust by using enum comparisons, improving the error message for better diagnostics, and adding a unit test to cover this new logic.

Comment thread agent.py Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@mquirosbloch mquirosbloch self-requested a review March 23, 2026 18:07
Copy link
Copy Markdown
Collaborator

@mquirosbloch mquirosbloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mquirosbloch mquirosbloch self-requested a review March 23, 2026 18:07
Copy link
Copy Markdown
Collaborator

@mquirosbloch mquirosbloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wt17 wt17 merged commit 4268ea4 into main Mar 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants