-
Notifications
You must be signed in to change notification settings - Fork 37
Fix GDTCCTUploader-upload Crash #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71d13b4 to
98f22dc
Compare
Coverage Report 1Affected ProductsNo changes between base commit (5a9a019) and merge commit (f6dbd63).Test Logs |
Member
|
firebase/firebase-ios-sdk#15129 is a different background task so this doesn't fix that one. |
ncooke3
reviewed
Dec 1, 2025
ncooke3
reviewed
Dec 1, 2025
Member
|
Will come back to this. Looks like the dead property was created in #3. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
ncooke3
reviewed
Dec 8, 2025
ncooke3
reviewed
Dec 8, 2025
ncooke3
reviewed
Dec 8, 2025
ncooke3
approved these changes
Dec 8, 2025
Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analysis from @ncooke3:
I'm pretty confident that this PR is valid code cleanup, but won't actually fix the crash.
Here's the order of events:
Gemini's summary:
Summary
The expirationHandler for the background task was attempting to cancel a non-existent currentTask property. This meant that if an upload task timed out, the operation would never be cancelled, and the background task identifier would never be released, leading to a warning from the OS and potential termination of the app.
The fix replaces the incorrect call with [self cancel], which correctly triggers the NSOperation's cancellation mechanism. This ensures that the operation terminates gracefully, allowing its promise chain to clean up and properly end the background task.
The CHANGELOG.md has also been updated to reflect this fix.