Skip to content

Conversation

@LukeSchlangen
Copy link

Updated Node.js and npm version requirements, adjusted project setup instructions, and modified package.json structure.

Might depend on google/adk-js#46

Updated Node.js and npm version requirements, adjusted project setup instructions, and modified package.json structure.
Copy link
Collaborator

@koverholt koverholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and improvements! Confirming that the tsc config and compilation step are not needed, and the quickstart is a smoother dev experience after removing them.

I tested all steps with adk-js and things are working for me, except I had to use zod@3 since the PR you linked is not yet merged. Using zod@4 results in an error: Unknown name "def" at 'tools[0].function_declarations[0].parameters'.

So this LGTM once that upstream PR is merged in adk-js. (I'll mark this PR as blocked for now)

Also pinging @joefernandez to review the changes since he worked on the original version of this quickstart.

@LukeSchlangen
Copy link
Author

What if we remove the explicit zod dependency? That's what we had in the original get-started, so I think it should still work? (Need to test it.)

Then we can do a separate PR for the zod update when that's ready?

@LukeSchlangen
Copy link
Author

Tested! It works. I removed Zod 4. I think it's good to merge if that works for you!

Copy link
Collaborator

@koverholt koverholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. Confirming that I tested the latest version and it works as expected without zod, except for an issue with the model string that I left a comment about. Also left some other comments about potential tweaks.

@koverholt
Copy link
Collaborator

And once those comments are addressed, I will pass to @joefernandez for review since this is a heavily visited page / entrypoint.

@koverholt
Copy link
Collaborator

koverholt commented Jan 29, 2026

Thanks for the updates! There is an issue with the CLA check due to commits from a different GitHub account. Can you rebase to switch authorship of those commits, or otherwise fix the failing CLA check? Might have happened due to misconfigured git config user / email.

https://github.com/google/adk-docs/pull/1196/checks?check_run_id=61911522036

@LukeSchlangen
Copy link
Author

I wasn't smart enough to figure out how to do that, so I'll close this one and open a new PR with the correct email: #1201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants