Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions core/src/tools/mcp/mcp_session_manager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,10 @@ import {
StdioClientTransport,
StdioServerParameters,
} from '@modelcontextprotocol/sdk/client/stdio.js';
import {StreamableHTTPClientTransport} from '@modelcontextprotocol/sdk/client/streamableHttp.js';
import {
StreamableHTTPClientTransport,
StreamableHTTPClientTransportOptions,
} from '@modelcontextprotocol/sdk/client/streamableHttp.js';

/**
* Defines the parameters for establishing a connection to an MCP server using
Expand All @@ -35,10 +38,15 @@ export interface StdioConnectionParams {
export interface StreamableHTTPConnectionParams {
type: 'StreamableHTTPConnectionParams';
url: string;
/**
* @deprecated
* Use transportOptions.requestInit.headers instead.
*/
header?: Record<string, unknown>;
timeout?: number;
sseReadTimeout?: number;
terminateOnClose?: boolean;
transportOptions?: StreamableHTTPClientTransportOptions;
}

/**
Expand Down Expand Up @@ -78,18 +86,21 @@ export class MCPSessionManager {
);
break;
case 'StreamableHTTPConnectionParams': {
let transportOptions;
if (this.connectionParams.header) {
transportOptions = {
requestInit: {
headers: this.connectionParams.header as Record<string, string>,
},
const options = this.connectionParams.transportOptions ?? {};

if (
!options.requestInit &&
this.connectionParams.header !== undefined
) {
options.requestInit = {
headers: this.connectionParams.header as Record<string, string>,
};
}

await client.connect(
new StreamableHTTPClientTransport(
new URL(this.connectionParams.url),
transportOptions,
options,
),
);
break;
Expand Down
134 changes: 134 additions & 0 deletions core/test/tools/mcp/mcp_session_manager_test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,134 @@
/**
* @license
* Copyright 2025 Google LLC
* SPDX-License-Identifier: Apache-2.0
*/

import {Client} from '@modelcontextprotocol/sdk/client/index.js';
import {StdioClientTransport} from '@modelcontextprotocol/sdk/client/stdio.js';
import {StreamableHTTPClientTransport} from '@modelcontextprotocol/sdk/client/streamableHttp.js';
import {describe, expect, it, vi} from 'vitest';
import {MCPSessionManager} from '../../../src/tools/mcp/mcp_session_manager.js';

vi.mock('@modelcontextprotocol/sdk/client/index.js', () => {
return {
Client: vi.fn().mockImplementation(() => ({
connect: vi.fn().mockResolvedValue(undefined),
})),
};
});

vi.mock('@modelcontextprotocol/sdk/client/stdio.js', () => {
return {
StdioClientTransport: vi.fn(),
};
});

vi.mock('@modelcontextprotocol/sdk/client/streamableHttp.js', () => {
return {
StreamableHTTPClientTransport: vi.fn(),
};
});

describe('MCPSessionManager', () => {
it('creates an stdio client', async () => {
const manager = new MCPSessionManager({
type: 'StdioConnectionParams',
serverParams: {
command: 'test-command',
args: ['arg1', 'arg2'],
},
});

const client = await manager.createSession();

expect(Client).toHaveBeenCalledWith({
name: 'MCPClient',
version: '1.0.0',
});
expect(StdioClientTransport).toHaveBeenCalledWith({
command: 'test-command',
args: ['arg1', 'arg2'],
});
expect(client.connect).toHaveBeenCalled();
});

it('creates an http client with transport options headers', async () => {
const manager = new MCPSessionManager({
type: 'StreamableHTTPConnectionParams',
url: 'http://test-url',
transportOptions: {
requestInit: {
headers: {
'x-test-header': 'test-value',
},
},
},
});

const client = await manager.createSession();

expect(Client).toHaveBeenCalledWith({
name: 'MCPClient',
version: '1.0.0',
});
expect(StreamableHTTPClientTransport).toHaveBeenCalledWith(
new URL('http://test-url'),
{
requestInit: {
headers: {'x-test-header': 'test-value'},
},
},
);
expect(client.connect).toHaveBeenCalled();
});

it('creates an http client with deprecated header param', async () => {
const manager = new MCPSessionManager({
type: 'StreamableHTTPConnectionParams',
url: 'http://test-url',
header: {
'x-test-header': 'test-value',
},
});

await manager.createSession();

expect(StreamableHTTPClientTransport).toHaveBeenCalledWith(
new URL('http://test-url'),
{
requestInit: {
headers: {'x-test-header': 'test-value'},
},
},
);
});

it('prioritizes transportOptions headers over header', async () => {
const manager = new MCPSessionManager({
type: 'StreamableHTTPConnectionParams',
url: 'http://test-url',
transportOptions: {
requestInit: {
headers: {
'x-priority': 'headers',
},
},
},
header: {
'x-priority': 'header',
},
});

await manager.createSession();

expect(StreamableHTTPClientTransport).toHaveBeenCalledWith(
expect.any(URL),
{
requestInit: {
headers: {'x-priority': 'headers'},
},
},
);
});
});
Loading